Skip to content

Change InlineQueryResultType.MPEG to more correct #1146

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

Desiders
Copy link
Contributor

Description

Change type of result in InlineQueryResult enum for InlineQueryResultCachedMpeg4Gif] and InlineQueryResultMpeg4Gif to more correct according to documentation

Type of change

  • Documentation (typos, code examples or any documentation update)
  • Bug fix (non-breaking change which fixes an issue)

@github-actions
Copy link

github-actions bot commented Mar 18, 2023

✔️ Changelog found.

Thank you for adding a description of the changes

@github-actions github-actions bot added the 3.x Issue or PR for stable 3.x version label Mar 18, 2023
@JrooTJunior
Copy link
Member

This part of code should not be changed manually, because we uses codegeneration and this fields will be changed again.

You can try to fix it here: https://github.com/aiogram/butcher
And here: https://github.com/aiogram/aiogram/tree/dev-3.x/.butcher

Or just provide an MRE to check this feature.

@Desiders Desiders changed the title Change InlineQueryResultType.MPEG to InlineQueryResultType.MPEG4GIF Change InlineQueryResultType.MPEG to more correct Mar 19, 2023
@JrooTJunior JrooTJunior merged commit 46a7beb into aiogram:dev-3.x Apr 8, 2023
JrooTJunior added a commit that referenced this pull request Apr 16, 2023
* Added missing FORUM_TOPIC_EDITED value to content_type property

* Added changelog to CHANGES

* Fixed aiogram/filters/magic_data.py:21:41: C416 Unnecessary `dict` comprehension (rewrite using `dict()`)

* Resolve  #1155: Different signature of startup/shutdown events on polling and webhooks  (#1156)

* Code refactor
- Use 'or' istead of 'A if A else B'
- Raise new error from catched error: raise Error from e

* Fixed signature of startup/shutdown events
- Include the **dispatcher.workflow_data as the handler arguments

* Update deep_linking basic examples (#1151)

* skip if current router does not have observer for custom event (#1147)

* skip if current router does not have observer for custom event

* Test custom event in router

* Feature changelog file

* fix style

* Change `InlineQueryResultType.MPEG` to more correct (#1146)

* Change `InlineQueryResultType.MPEG` to `InlineQueryResultType.MPEG4GIF`

* Change regexp for parse entities

* Use code generator to fix types

* Add changelog

* fix(docs): fix wrong page link in docs (#1154)

* storage cleanup (#1144)

* storage cleanup

* storage cleanup

* Update API docs

* Added tests

* Fix tests

---------

Co-authored-by: Alex Root Junior <jroot.junior@gmail.com>
Co-authored-by: Łukasz Tshipenchko <dev@zxc.sx>
Co-authored-by: Max Kotsiuruba <81016938+A5KET@users.noreply.github.com>
Co-authored-by: Andrey Tikhonov <andrey.tikhonov@quantori.com>
Co-authored-by: Desiders <47452083+Desiders@users.noreply.github.com>
Co-authored-by: Daniil <hum4noid@yandex.ru>
Co-authored-by: RootShinobi <111008396+RootShinobi@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3.x Issue or PR for stable 3.x version
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants