Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added missing FORUM_TOPIC_EDITED value to content_type property #1160

Merged
merged 12 commits into from
Apr 16, 2023
Merged

Added missing FORUM_TOPIC_EDITED value to content_type property #1160

merged 12 commits into from
Apr 16, 2023

Conversation

MasterGroosha
Copy link
Contributor

Description

Added missing FORUM_TOPIC_EDITED value to content_type property
Fixes #1159

Type of change

Please delete options that are not relevant.

  • Documentation (typos, code examples or any documentation update)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@github-actions github-actions bot added the 3.x Issue or PR for stable 3.x version label Apr 8, 2023
@github-actions
Copy link

github-actions bot commented Apr 8, 2023

✔️ Changelog found.

Thank you for adding a description of the changes

Copy link
Member

@JrooTJunior JrooTJunior left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To fix C416 please merge the latest dev-3.x branch.

aiogram/filters/magic_data.py:21:41: C416 Unnecessary `dict` comprehension (rewrite using `dict()`)

aiogram/types/message.py Show resolved Hide resolved
JrooTJunior and others added 9 commits April 10, 2023 22:16
…ing and webhooks (#1156)

* Code refactor
- Use 'or' istead of 'A if A else B'
- Raise new error from catched error: raise Error from e

* Fixed signature of startup/shutdown events
- Include the **dispatcher.workflow_data as the handler arguments
* skip if current router does not have observer for custom event

* Test custom event in router

* Feature changelog file

* fix style
* Change `InlineQueryResultType.MPEG` to `InlineQueryResultType.MPEG4GIF`

* Change regexp for parse entities

* Use code generator to fix types

* Add changelog
* storage cleanup

* storage cleanup
@MasterGroosha
Copy link
Contributor Author

@JrooTJunior I added tests but I cannot run tests properly due to lots of errors and lack of "preparing testing environment" documentation.
Please test changes yourself or provide more docs.

make tests -> No module named redis.
Okay, pip install redis.
make tests -> ModuleNotFoundError: No module named 'magic_filter'
Is there one command to install all dependencies for those who hasn't used hatch before?

@codecov
Copy link

codecov bot commented Apr 16, 2023

Codecov Report

Merging #1160 (b7d0ee1) into dev-3.x (fea1b7b) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##           dev-3.x     #1160   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          354       354           
  Lines         8791      8797    +6     
=========================================
+ Hits          8791      8797    +6     
Flag Coverage Δ
unittests 100.00% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
aiogram/client/bot.py 100.00% <ø> (ø)
aiogram/filters/magic_data.py 100.00% <ø> (ø)
aiogram/types/keyboard_button_request_chat.py 100.00% <ø> (ø)
aiogram/types/keyboard_button_request_user.py 100.00% <ø> (ø)
aiogram/utils/deep_linking.py 100.00% <ø> (ø)
aiogram/dispatcher/dispatcher.py 100.00% <100.00%> (ø)
aiogram/dispatcher/event/telegram.py 100.00% <100.00%> (ø)
aiogram/dispatcher/router.py 100.00% <100.00%> (ø)
aiogram/enums/inline_query_result_type.py 100.00% <100.00%> (ø)
aiogram/fsm/context.py 100.00% <100.00%> (ø)
... and 9 more

@JrooTJunior JrooTJunior merged commit 8d2bf20 into aiogram:dev-3.x Apr 16, 2023
@MasterGroosha MasterGroosha deleted the fix-1159-forum-topic-edited branch April 17, 2023 04:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3.x Issue or PR for stable 3.x version
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing FORUM_TOPIC_EDITED when detecting message content_type
8 participants