Skip to content

Fix markdown spoiler #1176

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 13, 2023
Merged

Conversation

NiKuma0
Copy link
Contributor

@NiKuma0 NiKuma0 commented May 10, 2023

Description

In telegram bot api documentation said that need two characters, but there we have only one. I did catch a bug with this, but github issue I didn't find and don't want to create.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

I tested it on my own project, but you can use this code:

...
@router.message()
async def test(m: types.Message):
    return await m.answer(m.md_text)

@github-actions github-actions bot added the 3.x Issue or PR for stable 3.x version label May 10, 2023
@github-actions
Copy link

github-actions bot commented May 10, 2023

✔️ Changelog found.

Thank you for adding a description of the changes

@NiKuma0 NiKuma0 changed the title Fix spoiler Fix markdown spoiler May 10, 2023
Copy link
Member

@JrooTJunior JrooTJunior left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for you contribution!

Please add short explanation of the changes in CHANGES/1176.bugfix.rst file and update tests

@NiKuma0 NiKuma0 requested a review from JrooTJunior May 11, 2023 20:01
@JrooTJunior
Copy link
Member

image

... and update tests

I see that tests still not updated

Just look at test results: https://github.com/aiogram/aiogram/actions/runs/4951994811/jobs/8858509304?pr=1176

@codecov
Copy link

codecov bot commented May 12, 2023

Codecov Report

Merging #1176 (c8dd635) into dev-3.x (cf269e1) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##           dev-3.x     #1176   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          358       358           
  Lines         8841      8841           
=========================================
  Hits          8841      8841           
Flag Coverage Δ
unittests 100.00% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
aiogram/utils/text_decorations.py 100.00% <100.00%> (ø)

@JrooTJunior JrooTJunior merged commit c418689 into aiogram:dev-3.x May 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3.x Issue or PR for stable 3.x version
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants