Upgrade to py12 #1354
Merged
Upgrade to py12 #1354
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nachtalb
changed the title
✔️ Changelog found.Thank you for adding a description of the changes |
Nachtalb
commented
Nov 3, 2023
| handler_event.clear() | ||
| resp = await self.make_reqest(client=client) | ||
| assert resp.status == 200 | ||
| await asyncio.wait_for(handler_event.wait(), timeout=1) | ||
| await asyncio.wait_for(method_called_event.wait(), timeout=1) |
There was a problem hiding this comment.
FYI, a simple asyncio.sleep(0.00000000...1) would be enough as well. It just needs to be non-zero so that another task is scheduled before our assert. However, using a side effect and waiting for an event is more robust to future changes or inconsistencies across different installations.
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## dev-3.x #1354 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 369 369
Lines 9448 9449 +1
=========================================
+ Hits 9448 9449 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
JrooTJunior
approved these changes
Nov 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces compatibility updates for Python 3.12, addressing changes and deprecations to ensure seamless functionality with the latest Python version. Changes include updates to the GitHub Actions workflow, project configurations, dependency adjustments, and test case modifications to align with Python 3.12's features and the newly adopted PEP 678 enhancements.
Fixes # (No issue linked, direct improvement)
aiohttp(3.9.0b0), which is currently the only version compatible with Python 3.12, as discussed here.Type of change
How Has This Been Tested?
Testing was performed by installing the project and executing pytests across various Python versions with different extras enabled. The following environments were tested:
clidue to a dependency version conflictclianddocsdue to dependency version conflictsTest Configuration:
All tests pass across the tested configurations.
Checklist:
This is a draft PR as it relies on the beta version of
aiohttp(3.9.0b0), which is currently the only version compatible with Python 3.12, as discussed here.