Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create AdminFilter and rename IdFilter to IDFilter #182

Merged
merged 7 commits into from
Aug 15, 2019
Merged

Create AdminFilter and rename IdFilter to IDFilter #182

merged 7 commits into from
Aug 15, 2019

Conversation

ArsNotFound
Copy link
Contributor

@ArsNotFound ArsNotFound commented Aug 8, 2019

Description

Create AdminFilter as mentioned in #151. Also rename IdFilter to IDFilter because it is an abbreviation

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)
  • Documentation (typos, code examples or any documentation update)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Used test code as listened in example.

Test Configuration:

  • Operating System: Windows 10 Pro
  • Python version: 3.7.1

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have added tests that prove my fix is effective or that my feature works

Rename IdFilter to IDFilter as it is an abbreviation like URL
@JrooTJunior
Copy link
Member

Also this filter should be added to documentation in file docs/source/dispatcher/filters.rst

@JrooTJunior
Copy link
Member

In checklist you mark "I have added tests that prove my fix is effective or that my feature works" as completed but i dont see the tests. I'll uncheck this mark.

@JrooTJunior JrooTJunior mentioned this pull request Aug 9, 2019
8 tasks
@JrooTJunior JrooTJunior merged commit ca55fad into aiogram:dev-2.x Aug 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants