Skip to content

Fix message.get_full_command() #352

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 13, 2020
Merged

Fix message.get_full_command() #352

merged 3 commits into from
Jun 13, 2020

Conversation

eyev0
Copy link

@eyev0 eyev0 commented Jun 9, 2020

Description

Fixes #351

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • command, args = '/command'.split(maxsplit=1)
  • cmd_args = '/command'.split(maxsplit=1)
    command, args = cmd_args.pop(0), cmd_args.pop(0) if cmd_args else ''

Test Configuration:

  • Operating System: Linux Mint 19.3
  • Python version: 3.8.0

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Egor Dementyev and others added 2 commits June 11, 2020 20:21
Co-authored-by: Alex Root Junior <jroot.junior@gmail.com>
@eyev0
Copy link
Author

eyev0 commented Jun 11, 2020

commited and fixed typos

@JrooTJunior JrooTJunior merged commit 8d30c1d into aiogram:dev-2.x Jun 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

message.get_full_command() gives ValueError if no args are provided in command handler in v2.9
2 participants