Skip to content

Fix HTML characters escaping #409

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 29, 2020
Merged

Fix HTML characters escaping #409

merged 1 commit into from
Aug 29, 2020

Conversation

WhiteMemory99
Copy link
Contributor

@WhiteMemory99 WhiteMemory99 commented Aug 29, 2020

Description

html.escape replaces " and ' characters by default which is NOT required by Telegram and causes unexpected behavior with single quotes. quote=False argument fixes that.
image

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • My changes generate no new warnings

html.escape replaces " and ' characters by default, but it's not required by Telegram and causes unexpected behavior, quote=False argument fixes that.
Copy link
Contributor

@Latand Latand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I confirm this problem
image

@JrooTJunior JrooTJunior merged commit d8c6214 into aiogram:dev-2.x Aug 29, 2020
@WhiteMemory99 WhiteMemory99 deleted the patch-1 branch August 30, 2020 06:40
uburuntu pushed a commit to uburuntu/aiogram that referenced this pull request Oct 4, 2020
html.escape replaces " and ' characters by default, but it's not required by Telegram and causes unexpected behavior, quote=False argument fixes that.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants