-
-
Notifications
You must be signed in to change notification settings - Fork 871
Fix #413 parse entities positioning #414
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #413 parse entities positioning #414
Conversation
LGTM Can you also make backport to And that is something strange. When i check entity length after adding MarkdownV2 i didn't see the need to use |
I updated the code: added tests, refactored encoding to methods, but didn't manage to put surrogates methods inside |
in aiogram/tests/test_utils/test_text_decorations.py Lines 110 to 231 in 6f53f15
and at the end of list add item: [
markdown_decoration,
"🚀 i'm bold and italic and still bold",
[
MessageEntity(offset=3, length=34, type="bold"),
MessageEntity(offset=12, length=10, type="italic"),
],
"🚀 *i'm bold _and italic_\r and still bold*"
] |
Thanks for contribution 😉 |
* fix entity positioning in parse_entities() aiogram#413 * add tests and small fixes
Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context.
Fixes #413
Type of change
Please delete options that are not relevant.