Skip to content

I18n example patch (added docs and fixed typos) #419

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 10, 2020

Conversation

Olegt0rr
Copy link
Contributor

@Olegt0rr Olegt0rr commented Sep 10, 2020

Description

  1. Replaced one file translation to all project folder translation. It's more usable case.
  2. For e.g. --> E.g.. E.g. is short for exempli gratia which means simply for example. So if you write for e.g., you are in effect writing for for example.
  3. xargs replased with serveral lines, xargs is not appliable for Microsoft Windows users.
  4. Added info about translation tools and .po files location.
  5. Minor typo edits.

Type of change

  • Documentation (typos, code examples or any documentation update)
  • This change requires a documentation update

1. Replaced one file translation to all project folder translation. It's more usable case. 
2. `For e.g.` --> `E.g.`. E.g. is short for `exempli gratia` which means simply “for example.” So if you write for e.g., you are in effect writing `for for example`. 
3. `xargs` replased with serveral lines, `xargs` is not appliable for Microsoft Windows users. 
4. Added info about translation tools. 
5. Minor edits.
@Olegt0rr Olegt0rr added the docs Something is missing in docs label Sep 10, 2020
@Olegt0rr Olegt0rr self-assigned this Sep 10, 2020
@JrooTJunior JrooTJunior merged commit 56ffa00 into dev-2.x Sep 10, 2020
@Olegt0rr Olegt0rr deleted the i18n-example-patch branch September 10, 2020 20:54
uburuntu pushed a commit to uburuntu/aiogram that referenced this pull request Oct 4, 2020
* Update i18n example

1. Replaced one file translation to all project folder translation. It's more usable case. 
2. `For e.g.` --> `E.g.`. E.g. is short for `exempli gratia` which means simply “for example.” So if you write for e.g., you are in effect writing `for for example`. 
3. `xargs` replased with serveral lines, `xargs` is not appliable for Microsoft Windows users. 
4. Added info about translation tools. 
5. Minor edits.

* i18n middlaware typo fix

* i18n example header typo fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Something is missing in docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants