Skip to content

hotfix(dispatcher): when DP.loop None #424

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 14, 2020
Merged

hotfix(dispatcher): when DP.loop None #424

merged 1 commit into from
Sep 14, 2020

Conversation

uwinx
Copy link
Contributor

@uwinx uwinx commented Sep 14, 2020

property DP.loop may be None, executor and webhook view should both respect that

@uwinx uwinx self-assigned this Sep 14, 2020
@uwinx uwinx added the bug Something is wrong with the framework label Sep 14, 2020
Olegt0rr
Olegt0rr approved these changes Sep 14, 2020
View reviewed changes
Copy link
Contributor

@Olegt0rr Olegt0rr left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Executor checked. It's okay

  • polling
  • webhook

@JrooTJunior JrooTJunior merged commit 7c65344 into dev-2.x Sep 14, 2020
uburuntu pushed a commit to uburuntu/aiogram that referenced this pull request Oct 4, 2020
@uwinx @uburuntu
hotfix(dispatcher): prop DP.loop may be None, executor and webhook vi…
ac44bab 
…ew should respect that (aiogram#424)
@JrooTJunior JrooTJunior deleted the hotfix-executor-whooks-loop branch May 12, 2021 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JrooTJunior JrooTJunior JrooTJunior approved these changes

@Olegt0rr Olegt0rr Olegt0rr approved these changes

Assignees

@uwinx uwinx

Labels
bug Something is wrong with the framework
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@uwinx @JrooTJunior @Olegt0rr