Skip to content

Fixed optionality of some properties, add vcard argument to InputContactMessageContent constructor #473

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 5, 2020

Conversation

SvineruS
Copy link

@SvineruS SvineruS commented Dec 3, 2020

Description

Replaced the optionality of properties with more relevant ones.
Add vcard argument to InputContactMessageContent constructor

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Run all tests in tests folder

Test Configuration:

  • Operating System: Manjaro 20.2
  • Python version: 3.8.6

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@evgfilim1 evgfilim1 added the enhancement Make it better! label Dec 4, 2020
@JrooTJunior JrooTJunior merged commit ca45b24 into aiogram:dev-2.x Dec 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Make it better!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants