Skip to content

fix return value of FSMContextProxy's setdefault (#405) #491

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 10, 2021
Merged

fix return value of FSMContextProxy's setdefault (#405) #491

merged 1 commit into from
Jan 10, 2021

Conversation

Ibraheem-Asaad
Copy link

Description

setdefault to actually return the proper value

Fixes issue #405

Type of change

Bug fix (non-breaking change which fixes an issue)

@JrooTJunior
Copy link
Member

Duplicates #486. But author of #486 did not resolves an code-review messages. So that's mean this PR should be merged.

@JrooTJunior JrooTJunior merged commit 4fb4d6c into aiogram:dev-2.x Jan 10, 2021
@JrooTJunior JrooTJunior mentioned this pull request Jan 10, 2021
Closed
13 tasks
@evgfilim1 evgfilim1 added the bug Something is wrong with the framework label Jan 10, 2021
@Ibraheem-Asaad Ibraheem-Asaad deleted the setdefault-return-value-fix branch January 15, 2021 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JrooTJunior JrooTJunior JrooTJunior approved these changes

Assignees
No one assigned
Labels
bug Something is wrong with the framework
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Ibraheem-Asaad @JrooTJunior @evgfilim1