Skip to content

Add ability to .answer_* and .reply_* live location #497

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 20, 2021
Merged

Add ability to .answer_* and .reply_* live location #497

merged 3 commits into from
Feb 20, 2021

Conversation

mykolasolodukha
Copy link

Description

Added the ability to pass more parameters (kwargs) from methods Message().answer_location() and Message().reply_location() to self.bot.send_location()

Type of change

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

No tests run. I believe it's a small change and it doesn't break anything.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@evgfilim1 evgfilim1 added enhancement Make it better! new feature Missing feature labels Jan 12, 2021
@mykolasolodukha
Copy link
Author

@evgfilim1 @JrooTJunior WDYT?

@JrooTJunior
Copy link
Member

LGTM

@evgfilim1, what do you think?

Copy link
Contributor

@evgfilim1 evgfilim1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for contribution!

@evgfilim1 evgfilim1 merged commit 9de257e into aiogram:dev-2.x Feb 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Make it better! new feature Missing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants