-
-
Notifications
You must be signed in to change notification settings - Fork 891
FIX TelegramObject.__setitem__ #532
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Removed 'raise KeyError(key)'
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's not a fix, you're trying to brake validator instead
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks for PR!
Suggestion: We may use warning instead of KeyError |
When Telegram adds a new field -> Aiogram will warn about this.
Commit: d34e9c2 Example of warning in CLI:
Example of warning in log flie: |
Removed 'raise KeyError(key)'
Description
Fix error:
Fixes # (issue)
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
await msg.chat.update_chat()
Test Configuration:
Checklist: