Skip to content

[examples] Changed ChatType from CHANNEL to SUPERGROUP to avoid confusion #533

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 20, 2021
Merged

[examples] Changed ChatType from CHANNEL to SUPERGROUP to avoid confusion #533

merged 1 commit into from
Mar 20, 2021

Conversation

MasterGroosha
Copy link
Contributor

Description

Channels require a separate channel_post_handler, so this example is currently broken and confusing

Type of change

Please delete options that are not relevant.

  • Documentation (typos, code examples or any documentation update)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Manually

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Channels require a separate channel_post_handler, so this example is currently broken and confusing
@MasterGroosha MasterGroosha changed the title Changed ChatType from CHANNEL to SUPERGROUP to avoid confusion [examples] Changed ChatType from CHANNEL to SUPERGROUP to avoid confusion Mar 20, 2021
@evgfilim1 evgfilim1 added docs Something is missing in docs enhancement Make it better! labels Mar 20, 2021
@JrooTJunior JrooTJunior merged commit 9012704 into aiogram:dev-2.x Mar 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Something is missing in docs enhancement Make it better!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants