Skip to content

Fix Bot.*_chat_invite_link not returning ChatInviteLink (#548) #549

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 27, 2021
Merged

Fix Bot.*_chat_invite_link not returning ChatInviteLink (#548) #549

merged 1 commit into from
Apr 27, 2021

Conversation

darksidecat
Copy link
Contributor

@darksidecat darksidecat commented Mar 28, 2021

Bot.create_chat_invite_link()
Bot.edit_chat_invite_link()
Bot.revoke_chat_invite_link()

need to return types.ChatInviteLink, not dict

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context.

Fixes #548

Type of change

Please delete options that are not relevant.

  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Maybe this fix be breaking if users use dicts that was returned by these methods

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Methods return types.ChatInviteLink objects

Test Configuration:

  • Operating System: Win10
  • Python version: 3.9.2

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Bot.create_chat_invite_link()
Bot.edit_chat_invite_link()
Bot.revoke_chat_invite_link()

need to return types.ChatInviteLink, not dict
Copy link
Contributor

@evgfilim1 evgfilim1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for PR!

@evgfilim1 evgfilim1 added the bug Something is wrong with the framework label Mar 29, 2021
@evgfilim1 evgfilim1 added this to the 2.12.2 milestone Mar 29, 2021
@evgfilim1 evgfilim1 changed the title Closes #548 Fix Bot.*_chat_invite_link not returning ChatInviteLink (#548) Mar 29, 2021
@evgfilim1 evgfilim1 requested a review from JrooTJunior April 2, 2021 12:09
@evgfilim1 evgfilim1 modified the milestones: 2.12.2, 2.13 Apr 26, 2021
@JrooTJunior JrooTJunior merged commit 75e88f1 into aiogram:dev-2.x Apr 27, 2021
@darksidecat darksidecat deleted the #548-invite_link-return-type branch April 30, 2021 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something is wrong with the framework
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bot.******_chat_invite_link() return type does not match documentation
5 participants