New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace deprecated 'is_private' method #553

Merged

JrooTJunior merged 1 commit into aiogram:dev-2.x from LDmitriy7:dev-2.x

Apr 12, 2021

LDmitriy7 commented Apr 2, 2021 •

edited

Loading

Description

Property types.Message.url uses deprecated method 'is_private' when checks chat type. I've replaced it

Fixes #552

Type of change

Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Checked that property no longer raise DeprecationWarning

Operating System: Win10
Python version: 3.9.2

Checklist:

My code follows the style guidelines of this project
I have performed a self-review of my own code
I have made corresponding changes to the documentation
My changes generate no new warnings
I have added tests that prove my fix is effective or that my feature works
New and existing unit tests pass locally with my changes


          Replace deprecated 'is_private' method

e851840

JrooTJunior approved these changes

View reviewed changes

JrooTJunior merged commit df294e5 into aiogram:dev-2.x

evgfilim1 added the enhancement label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels