Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: builtin command filter args (#556) #558

Merged
merged 3 commits into from
Apr 28, 2021

Conversation

y-young
Copy link

@y-young y-young commented Apr 6, 2021

Description

Fixes #556

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • This change requires a documentation update

How Has This Been Tested?

  • Parse command with no argument
  • Parse command with one argument
  • Parse command with more than one arguments
  • Print CommandObj.text
  • Operating System: Windows 10
  • Python version: 3.8.1

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

aiogram/dispatcher/filters/builtin.py Outdated Show resolved Hide resolved
aiogram/dispatcher/filters/builtin.py Outdated Show resolved Hide resolved
@JrooTJunior
Copy link
Member

Also you can check how it works in dev-3.x branch
https://github.com/aiogram/aiogram/blob/dev-3.x/aiogram/dispatcher/filters/command.py#L47-L104

@y-young y-young requested a review from JrooTJunior April 12, 2021 08:04
@y-young
Copy link
Author

y-young commented Apr 23, 2021

@JrooTJunior Could you please review the changes?

@evgfilim1 evgfilim1 added the bug Something is wrong with the framework label Apr 24, 2021
aiogram/dispatcher/filters/builtin.py Outdated Show resolved Hide resolved
Co-authored-by: evgfilim1 <evgfilim1@yandex.ru>
@y-young y-young requested a review from evgfilim1 April 24, 2021 12:08
@y-young
Copy link
Author

y-young commented Apr 27, 2021

@JrooTJunior @evgfilim1 Please review the changes, thanks.

Copy link
Contributor

@evgfilim1 evgfilim1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for PR!

@evgfilim1 evgfilim1 added this to the 2.13 milestone Apr 28, 2021
@JrooTJunior JrooTJunior merged commit 35bf18c into aiogram:dev-2.x Apr 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something is wrong with the framework
Projects
None yet
Development

Successfully merging this pull request may close these issues.

'args' attribute of 'Command.CommandObj' seems not working
3 participants