Skip to content

Deep linking util fix #569

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 27, 2021
Merged

Deep linking util fix #569

merged 3 commits into from
Apr 27, 2021

Conversation

Olegt0rr
Copy link
Contributor

Description

  • fixed cases with ValueError before encoding
  • fixed test cases
  • refactored (code style, redundant functions, e.t.c.)
  • example enriched

Type of change

Please delete options that are not relevant.

  • Documentation (typos, code examples or any documentation update)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@Olegt0rr Olegt0rr requested a review from a team April 20, 2021 16:08
@Olegt0rr Olegt0rr added bug Something is wrong with the framework tests Something related to testing this framework labels Apr 20, 2021
@JrooTJunior JrooTJunior merged commit 08f0635 into dev-2.x Apr 27, 2021
@JrooTJunior JrooTJunior deleted the bug/deep-linking-util branch May 12, 2021 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something is wrong with the framework tests Something related to testing this framework
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants