Skip to content

iter states in states group #666

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Sep 5, 2021

Conversation

Tishka17
Copy link
Contributor

@Tishka17 Tishka17 commented Aug 17, 2021

Description

This allows to iterate over all states in StatesGroup.
Aiogram already had in check for states group so this is relative feature.

Type of change

Please delete options that are not relevant.

  • Documentation (typos, code examples or any documentation update)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • test_iterable

Test Configuration:

  • Operating System: Ubuntu 20.04.2 LTS
  • Python version: 3.8

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Copy link
Member

@JrooTJunior JrooTJunior left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. The PR description should be correctly filled
  2. Patch-notes should be added to CHANGES directory
    For example execute command towncrier create 666.feature and then write short description of the changes to newly created file named CHANGES/666.feature

@codecov
Copy link

codecov bot commented Aug 19, 2021

Codecov Report

Merging #666 (b28cabb) into dev-3.x (5851e32) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##           dev-3.x      #666   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          269       269           
  Lines         5658      5660    +2     
=========================================
+ Hits          5658      5660    +2     
Flag Coverage Δ
unittests 100.00% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
aiogram/dispatcher/fsm/state.py 100.00% <100.00%> (ø)

@JrooTJunior JrooTJunior merged commit 90b3a99 into aiogram:dev-3.x Sep 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants