Skip to content

Add middleware for logging outgoing requests #716

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

darksidecat
Copy link
Contributor

@darksidecat darksidecat commented Oct 4, 2021

Description

Add middleware for logging outgoing requests

Type of change

Please delete options that are not relevant.

  • Documentation (typos, code examples or any documentation update)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Add tests
  • Manual testing

Test Configuration:

  • Operating System: Win 10, Manjaro
  • Python version: 3.9.2

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

darksidecat and others added 2 commits October 5, 2021 23:40
Co-authored-by: Alex Root Junior <jroot.junior@gmail.com>
@codecov
Copy link

codecov bot commented Oct 5, 2021

Codecov Report

Merging #716 (91ffa15) into dev-3.x (275bd50) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##           dev-3.x      #716   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          269       271    +2     
  Lines         5968      6011   +43     
=========================================
+ Hits          5968      6011   +43     
Flag Coverage Δ
unittests 100.00% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
aiogram/client/session/aiohttp.py 100.00% <100.00%> (ø)
aiogram/client/session/base.py 100.00% <100.00%> (ø)
aiogram/client/session/middlewares/base.py 100.00% <100.00%> (ø)
...gram/client/session/middlewares/request_logging.py 100.00% <100.00%> (ø)
aiogram/exceptions.py 100.00% <0.00%> (ø)
aiogram/dispatcher/event/telegram.py 100.00% <0.00%> (ø)

@JrooTJunior
Copy link
Member

Oops. Changes file is required, i forgot about this... (CHANGES/716.feature)

@darksidecat
Copy link
Contributor Author

Oops. Changes file is required, i forgot about this... (CHANGES/716.feature)

added

@JrooTJunior JrooTJunior added 3.x Issue or PR for stable 3.x version breaking This breaks backwards-compatibility enhancement Make it better! labels Oct 5, 2021
@JrooTJunior JrooTJunior added this to the 3.0 milestone Oct 5, 2021
@JrooTJunior JrooTJunior merged commit 99c99ce into aiogram:dev-3.x Oct 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3.x Issue or PR for stable 3.x version breaking This breaks backwards-compatibility enhancement Make it better!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants