-
-
Notifications
You must be signed in to change notification settings - Fork 883
Bound filters resolving rework, filters with default argument #727
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
JrooTJunior
merged 10 commits into
aiogram:dev-3.x
from
darksidecat:dev-3.x-filter-resolving-rework
Oct 12, 2021
Merged
Bound filters resolving rework, filters with default argument #727
JrooTJunior
merged 10 commits into
aiogram:dev-3.x
from
darksidecat:dev-3.x-filter-resolving-rework
Oct 12, 2021
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* bound filters resolving rework, filters with default argument
Codecov Report
@@ Coverage Diff @@
## dev-3.x #727 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 272 272
Lines 7096 7104 +8
=========================================
+ Hits 7096 7104 +8
Flags with carried forward coverage won't be shown. Click here to find out more.
|
JrooTJunior
approved these changes
Oct 11, 2021
JrooTJunior
requested changes
Oct 11, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generator expression should be changed
Co-authored-by: Alex Root Junior <jroot.junior@gmail.com>
fix data transfer from parent to included routers filters
JrooTJunior
approved these changes
Oct 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
3.x
Issue or PR for stable 3.x version
breaking
This breaks backwards-compatibility
enhancement
Make it better!
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bound filters resolving rework
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Test Configuration:
Checklist: