Skip to content

Bound filters resolving rework, filters with default argument #727

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

darksidecat
Copy link
Contributor

@darksidecat darksidecat commented Oct 11, 2021

Bound filters resolving rework

  • Add autoresolving filters with default arguments for handlers in router
  • Disallow usage same filter type as positional filter and keyword based filter in one handler

Type of change

Please delete options that are not relevant.

  • Documentation (typos, code examples or any documentation update)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Add tests

Test Configuration:

  • Operating System: Win 10
  • Python version: 3.9.2

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

* bound filters resolving rework, filters with default argument
@codecov
Copy link

codecov bot commented Oct 11, 2021

Codecov Report

Merging #727 (fd5f9f2) into dev-3.x (3931253) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##           dev-3.x      #727   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          272       272           
  Lines         7096      7104    +8     
=========================================
+ Hits          7096      7104    +8     
Flag Coverage Δ
unittests 100.00% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
aiogram/dispatcher/event/telegram.py 100.00% <100.00%> (ø)

@JrooTJunior JrooTJunior added 3.x Issue or PR for stable 3.x version breaking This breaks backwards-compatibility enhancement Make it better! labels Oct 11, 2021
@JrooTJunior JrooTJunior added this to the 3.0 milestone Oct 11, 2021
@JrooTJunior JrooTJunior self-requested a review October 11, 2021 18:59
Copy link
Member

@JrooTJunior JrooTJunior left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generator expression should be changed

@JrooTJunior JrooTJunior merged commit 42cba89 into aiogram:dev-3.x Oct 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3.x Issue or PR for stable 3.x version breaking This breaks backwards-compatibility enhancement Make it better!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants