Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix resolve filters chain #736

Merged

Conversation

darksidecat
Copy link
Contributor

Description

Bound filter resolving does not require children routers

Type of change

Please delete options that are not relevant.

  • Documentation (typos, code examples or any documentation update)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Run local tests

Test Configuration:

  • Operating System: Win 10
  • Python version: 3.9.2

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@codecov
Copy link

codecov bot commented Oct 22, 2021

Codecov Report

Merging #736 (2b7f054) into dev-3.x (42cba89) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##           dev-3.x      #736   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          272       272           
  Lines         7105      7108    +3     
=========================================
+ Hits          7105      7108    +3     
Flag Coverage Δ
unittests 100.00% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
aiogram/dispatcher/router.py 100.00% <ø> (ø)
aiogram/dispatcher/event/telegram.py 100.00% <100.00%> (ø)
aiogram/dispatcher/dispatcher.py 100.00% <0.00%> (ø)
aiogram/dispatcher/event/handler.py 100.00% <0.00%> (ø)
aiogram/dispatcher/filters/command.py 100.00% <0.00%> (ø)

@JrooTJunior JrooTJunior added the 3.x Issue or PR for stable 3.x version label Oct 22, 2021
@JrooTJunior JrooTJunior merged commit 19aa498 into aiogram:dev-3.x Nov 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3.x Issue or PR for stable 3.x version
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants