Skip to content

Fix ChatMemberHandler import in __init__.py #751

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 24, 2021
Merged

Fix ChatMemberHandler import in __init__.py #751

merged 3 commits into from
Nov 24, 2021

Conversation

WhiteMemory99
Copy link
Contributor

@WhiteMemory99 WhiteMemory99 commented Nov 19, 2021

Description

The ChatMemberUpdated class is being imported instead of ChatMemberHandler, which is wrong here.

Type of change

Please delete options that are not relevant.

  • Documentation (typos, code examples or any documentation update)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Test Configuration:

  • Operating System:
  • Python version:

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@JrooTJunior JrooTJunior added 3.x Issue or PR for stable 3.x version bug Something is wrong with the framework labels Nov 20, 2021
@codecov
Copy link

codecov bot commented Nov 20, 2021

Codecov Report

Merging #751 (5143c62) into dev-3.x (812fb87) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##           dev-3.x      #751   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          278       278           
  Lines         7316      7316           
=========================================
  Hits          7316      7316           
Flag Coverage Δ
unittests 100.00% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
aiogram/dispatcher/handler/__init__.py 100.00% <100.00%> (ø)

@JrooTJunior
Copy link
Member

Can you please try to update your branch with the latest changes of dev-3.x?

I'm not sure why tests failed only on Windows with Python 3.9 but now it works in the dev-3.x branch.

@WhiteMemory99
Copy link
Contributor Author

Can you please try to update your branch with the latest changes of dev-3.x?

I'm not sure why tests failed only on Windows with Python 3.9 but now it works in the dev-3.x branch.

Done!

Copy link
Contributor

@evgfilim1 evgfilim1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for PR!

@JrooTJunior
Copy link
Member

Perfect

@JrooTJunior JrooTJunior merged commit a48a32a into aiogram:dev-3.x Nov 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3.x Issue or PR for stable 3.x version bug Something is wrong with the framework
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants