Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix unexpected behavior of sequences in StateFilter #791

Merged
merged 3 commits into from
Dec 29, 2021
Merged

Fix unexpected behavior of sequences in StateFilter #791

merged 3 commits into from
Dec 29, 2021

Conversation

WhiteMemory99
Copy link
Contributor

@WhiteMemory99 WhiteMemory99 commented Dec 19, 2021

Description

At the moment of preparing this PR, the StateFilter, given a sequence of values, makes a check only for its first element, which results in unexpected behavior for developers using the framework.

Type of change

  • Documentation (typos, code examples or any documentation update)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Test Configuration:

  • Operating System: Windows 11
  • Python version: 3.9.6

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@codecov
Copy link

codecov bot commented Dec 19, 2021

Codecov Report

Merging #791 (45df610) into dev-3.x (7c14a6b) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##           dev-3.x      #791   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          280       280           
  Lines         7377      7378    +1     
=========================================
+ Hits          7377      7378    +1     
Flag Coverage Δ
unittests 100.00% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
aiogram/dispatcher/filters/state.py 100.00% <100.00%> (ø)

@JrooTJunior JrooTJunior merged commit 6e39f9f into aiogram:dev-3.x Dec 29, 2021
@DimonAgon
Copy link

Appreciate you for work done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants