Skip to content

Added changelog changed validator #873

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Mar 26, 2022
Merged

Conversation

JrooTJunior
Copy link
Member

@JrooTJunior JrooTJunior commented Mar 26, 2022

Description

In many cases contributors forget to add description of the changes to CHANGES/ directory, so we need to validate that automatically via GutHub Actions

Type of change

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Via current pull-request

Screenshot_20220326_193657
Screenshot_20220326_194112

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@JrooTJunior JrooTJunior added enhancement Make it better! 3.x Issue or PR for stable 3.x version labels Mar 26, 2022
@JrooTJunior JrooTJunior added this to the 3.0 milestone Mar 26, 2022
@codecov
Copy link

codecov bot commented Mar 26, 2022

Codecov Report

Merging #873 (1ec67d9) into dev-3.x (baf31a5) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           dev-3.x      #873   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          284       284           
  Lines         7784      7784           
=========================================
  Hits          7784      7784           
Flag Coverage Δ
unittests 100.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@github-actions
Copy link

github-actions bot commented Mar 26, 2022

✔️ Changelog found.

Thank you for adding a description of the changes

@JrooTJunior JrooTJunior requested a review from a team March 26, 2022 17:55
@JrooTJunior JrooTJunior merged commit b8aa03b into dev-3.x Mar 26, 2022
@JrooTJunior JrooTJunior deleted the dev-3.x-require-changelog branch June 25, 2022 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3.x Issue or PR for stable 3.x version enhancement Make it better!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant