Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix escaping for markdown #903

Closed
wants to merge 1 commit into from
Closed

Conversation

venticello
Copy link

@venticello venticello commented May 7, 2022

Description

Fix escaping forbidden characters for markdown. The wrong decorator was used.

Fixes # (issue)

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Fix escaping forbidden characters for markdown. The wrong decorator was used.
@github-actions
Copy link

github-actions bot commented May 7, 2022

❌ Changelog is required!

You need to add a brief description of the changes to the CHANGES directory.

For example, you can run towncrier create <issue>.<type> to create a file in the change directory and then write a description on that file.

Read more at Towncrier docs

@codecov
Copy link

codecov bot commented May 7, 2022

Codecov Report

Merging #903 (9586bad) into dev-3.x (f2e02e2) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##           dev-3.x      #903   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          300       300           
  Lines         8172      8172           
=========================================
  Hits          8172      8172           
Flag Coverage Δ
unittests 100.00% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
aiogram/utils/markdown.py 100.00% <100.00%> (ø)

@JrooTJunior JrooTJunior added bug Something is wrong with the framework 3.x Issue or PR for stable 3.x version labels May 8, 2022
@JrooTJunior JrooTJunior added this to the 3.0 milestone May 8, 2022
Copy link
Member

@JrooTJunior JrooTJunior left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add test that prove your fix and prevent to break this feature in the future

Also the short description of changes should be added as described above.

@JrooTJunior
Copy link
Member

@venticello, any news?

@evgfilim1 evgfilim1 added the stale "Dead" or inactive issue label Jun 23, 2022
@JrooTJunior
Copy link
Member

Fixed in dev-3.x directly in due to author of this PR did not respond in too long time

@JrooTJunior JrooTJunior closed this Oct 1, 2022
@evgfilim1 evgfilim1 removed this from the 3.0 milestone Nov 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3.x Issue or PR for stable 3.x version bug Something is wrong with the framework stale "Dead" or inactive issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants