Fix type hints for redis TTL params #922
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✔️ Changelog found.Thank you for adding a description of the changes |
JrooTJunior
added
docs
Olegt0rr
approved these changes
Jun 13, 2022
Olegt0rr
suggested changes
Jun 13, 2022
Codecov Report
@@ Coverage Diff @@
## dev-3.x #922 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 300 300
Lines 8183 8184 +1
=========================================
+ Hits 8183 8184 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Olegt0rr
reviewed
Jun 14, 2022
CHANGES/922.feature.rst
Outdated
| @@ -0,0 +1 @@ | |||
| Allowed to use int and datetime.timedelta in RedisStorage.state_ttl and RedisStorage.data_ttl | |||
There was a problem hiding this comment.
It was allowed before, but with wrong type hinting
May be write something like
Fixed type hints for redis TTL params?
Olegt0rr
approved these changes
Jun 15, 2022
JrooTJunior
approved these changes
Jun 15, 2022
Olegt0rr
changed the title
int and datetime.timedelta in RedisStorage.state_ttl and RedisStorage.data_ttl
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Use
floatanddatetime.timedeltatype hints inRedisStorage.state_ttlandRedisStorage.data_ttl.Let's reuse type hint
ExpiryTfrom redis.Type of change
Checklist: