-
-
Notifications
You must be signed in to change notification settings - Fork 884
Add full_name
shortcut for Chat
#929
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✔️ Changelog found.Thank you for adding a description of the changes |
Codecov Report
@@ Coverage Diff @@
## dev-3.x #929 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 300 300
Lines 8184 8191 +7
=========================================
+ Hits 8184 8191 +7
Flags with carried forward coverage won't be shown. Click here to find out more.
|
@@ -0,0 +1 @@ | |||
Added `full_name` shortcut for `Chat` object |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Question to maintainers: What's better in your opinion, past tense like this (Added ...) or present tense like in commit messages (Add ...)? I personally prefer the latter.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I prefer the former because change log is historical data
Present tense looks like TODO list with unfinished tasks:
Update v1:
- Add foo
Update v2:
- Fix bar
Past tense looks like a list of things already done:
Update v1:
- Added foo
Update v2:
- Fixed bar
Description
In some cases it's handy to get user's current params via
get_chat
method.Then you want to use
full_name
shortcut similar toUser
, but it's absent forChat
... :(So, may be add it? :)
Type of change
Please delete options that are not relevant.
Checklist: