Skip to content

Add full_name shortcut for Chat #929

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 25, 2022
Merged

Add full_name shortcut for Chat #929

merged 4 commits into from
Jun 25, 2022

Conversation

Olegt0rr
Copy link
Contributor

@Olegt0rr Olegt0rr commented Jun 20, 2022

Description

In some cases it's handy to get user's current params via get_chat method.
Then you want to use full_name shortcut similar to User, but it's absent for Chat... :(

So, may be add it? :)

Type of change

Please delete options that are not relevant.

  • Ported 2.x feature (non-breaking change which adds functionality)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@Olegt0rr Olegt0rr added enhancement Make it better! 3.x Issue or PR for stable 3.x version labels Jun 20, 2022
@github-actions
Copy link

github-actions bot commented Jun 20, 2022

✔️ Changelog found.

Thank you for adding a description of the changes

@codecov
Copy link

codecov bot commented Jun 20, 2022

Codecov Report

Merging #929 (d53626e) into dev-3.x (adfc89f) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##           dev-3.x      #929   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          300       300           
  Lines         8184      8191    +7     
=========================================
+ Hits          8184      8191    +7     
Flag Coverage Δ
unittests 100.00% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
aiogram/types/chat.py 100.00% <100.00%> (ø)

@Olegt0rr Olegt0rr added the new feature Missing feature label Jun 20, 2022
@Olegt0rr Olegt0rr requested a review from a team June 20, 2022 15:02
@@ -0,0 +1 @@
Added `full_name` shortcut for `Chat` object
Copy link
Contributor

@evgfilim1 evgfilim1 Jun 23, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Question to maintainers: What's better in your opinion, past tense like this (Added ...) or present tense like in commit messages (Add ...)? I personally prefer the latter.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I prefer the former because change log is historical data

Present tense looks like TODO list with unfinished tasks:

Update v1:

  • Add foo

Update v2:

  • Fix bar

Past tense looks like a list of things already done:

Update v1:

  • Added foo

Update v2:

  • Fixed bar

@JrooTJunior JrooTJunior merged commit 70088cd into dev-3.x Jun 25, 2022
@JrooTJunior JrooTJunior deleted the full_name-for-chat branch February 12, 2023 00:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3.x Issue or PR for stable 3.x version enhancement Make it better! new feature Missing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants