Skip to content

Fix default lock kwargs in RedisEventIsolation #972

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 9, 2022

Conversation

WhiteMemory99
Copy link
Contributor

@WhiteMemory99 WhiteMemory99 commented Aug 7, 2022

Description

After the event isolation was rewritten, default Redis lock kwargs, specifically timeout, were left out, causing locks to be permanent, which might result in some users being continuously ignored in case the bot is restarted during the update processing.

Type of change

  • Bug fix (non-breaking change that fixes an issue)

How has this been tested?

Test Configuration

  • Operating system: Windows 11
  • Python version: 3.10.6

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have added tests that prove my fix is effective or that my feature works as expected
  • New and existing unit tests pass locally with my changes
  • My changes generate no new warnings or errors
  • My changes are compatible with minimum requirements of the project
  • I have made corresponding changes to the documentation

@github-actions github-actions bot added the 3.x Issue or PR for stable 3.x version label Aug 7, 2022
@github-actions
Copy link

github-actions bot commented Aug 7, 2022

✔️ Changelog found.

Thank you for adding a description of the changes

@codecov
Copy link

codecov bot commented Aug 7, 2022

Codecov Report

Merging #972 (611db5a) into dev-3.x (851f7a2) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##           dev-3.x      #972   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          303       303           
  Lines         8179      8178    -1     
=========================================
- Hits          8179      8178    -1     
Flag Coverage Δ
unittests 100.00% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
aiogram/dispatcher/fsm/storage/redis.py 100.00% <100.00%> (ø)

@JrooTJunior JrooTJunior merged commit 5e7932c into aiogram:dev-3.x Aug 9, 2022
@WhiteMemory99 WhiteMemory99 deleted the patch-1 branch August 9, 2022 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3.x Issue or PR for stable 3.x version
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants