Prevent to crash polling #995
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JrooTJunior
added
bug
✔️ Changelog found.Thank you for adding a description of the changes |
Codecov Report
@@ Coverage Diff @@
## dev-3.x #995 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 303 303
Lines 8216 8216
=========================================
Hits 8216 8216
Flags with carried forward coverage won't be shown. Click here to find out more.
|
evgfilim1
reviewed
Aug 29, 2022
| except (TelegramNetworkError, TelegramServerError) as e: | ||
| # In cases when Telegram Bot API was inaccessible don't need to stop polling process | ||
| # because some of developers can't make auto-restarting of the script | ||
| except Exception as e: |
There was a problem hiding this comment.
Maybe this would be better? Too broad except clause can be bad, even if we won't get any other error.
Suggested change
| except Exception as e: | |
| except TelegramAPIError as e: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Sometime Telegram restart the server with HTTP 429 error, so that's mean we need to handle it in polling mode
Type of change
Checklist: