Enhanced logger #502
Enhanced logger #502
Conversation
There was a problem hiding this comment.
In addition to the specific comments, please:
- update the default config in
modBoot/resources/config.xml(with the comments) - ensure the license for each file conforms to https://github.com/aionnetwork/aion/wiki/Aion-License-Header
|
|
||
| /** XML - Displays log-path in the config.xml */ | ||
| xmlWriter.writeCharacters("\t\t"); | ||
| xmlWriter.writeStartElement("log-path"); |
There was a problem hiding this comment.
could you add comments here regarding the meaning of the configuration (similar to the ones in the api and db)
There was a problem hiding this comment.
Added comments into the config.xml file
modBoot/src/org/aion/Aion.java
Outdated
| System.out.println("Logger file path: '" + cfg.getLog().getLogPath() + "'\n"); | ||
| } | ||
|
|
||
| // If commit this out, the config setting will be ignore. all log module been set to "INFO" Level |
There was a problem hiding this comment.
not clear what that comment is mean to say
|
|
||
| loggerContext = (LoggerContext) LoggerFactory.getILoggerFactory(); | ||
|
|
||
| /** Toggles file appending configurations */ |
There was a problem hiding this comment.
could you switch all the comments that use the java doc notation /** to the comment notation /* throughout all the files of the PR
There was a problem hiding this comment.
Changed the comment notation and added the license headers to relevant files
…o enhance_logger
| @@ -104,6 +104,8 @@ public String toXML() { | |||
| * Boolean value to allow logger to be toggled ON and OFF | |||
| */ | |||
| xmlWriter.writeCharacters("\t\t"); | |||
| xmlWriter.writeCharacters("<!--Enable/Disable logback service; if disabled, output will not be logged -->"); | |||
There was a problem hiding this comment.
you need to use writeComment here like in
aion/modMcf/src/org/aion/mcf/config/CfgDb.java
Lines 195 to 200 in 1bbeec1
| @@ -114,6 +116,8 @@ public String toXML() { | |||
| * String value to determine the folder path for log files | |||
| */ | |||
| xmlWriter.writeCharacters("\t\t"); | |||
| xmlWriter.writeCharacters("<!--Sets the physical location on disk where log files will be stored.-->"); | |||
There was a problem hiding this comment.
same as before, need to use writeComment and remove the comment tags
Description
Added additional functionality and configuration to existing logger system;
Fixes Issue # .
Type of change
Insert x into the following checkboxes to confirm (eg. [x]):
Testing
Please describe the tests you used to validate this pull request. Provide any relevant details for test configurations as well as any instructions to reproduce these results.
Verification
Insert x into the following checkboxes to confirm (eg. [x]):