Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix TxReceiptLog address issue #656

Merged
merged 4 commits into from Oct 9, 2018

Conversation

Projects
None yet
5 participants
@AionJayT
Copy link
Collaborator

commented Oct 2, 2018

Notice

It is not allowed to submit your PR to the master branch directly, please submit your PR to the master-pre-merge branch.

Description

Fix bug reported by Mavennet. The transaction log receipt gives the wrong address (always the entry contract address) when the transaction using one contract call another contract.

Fixes Issue # .

Type of change

Insert x into the following checkboxes to confirm (eg. [x]):

  • Bug fix.
  • New feature.
  • Enhancement.
  • Unit test.
  • Breaking change (a fix or feature that causes existing functionality to not work as expected).
  • Requires documentation update.

Testing

Please describe the tests you used to validate this pull request. Provide any relevant details for test configurations as well as any instructions to reproduce these results.

  • It has tested by JAVA-API contract integration test. @beidouz will update the testcase also Mavennet approved the fix works.

Verification

Insert x into the following checkboxes to confirm (eg. [x]):

  • I have self-reviewed my own code and conformed to the style guidelines of this project.
  • New and existing tests pass locally with my changes.
  • I have added tests for my fix or feature.
  • I have made appropriate changes to the corresponding documentation.
  • My code generates no new warnings.
  • Any dependent changes have been made.

@AionJayT AionJayT added the bug label Oct 2, 2018

@AionJayT AionJayT added this to the 0.3.2 milestone Oct 2, 2018

* Copyright (c) 2017-2018 Aion foundation.
*
* This file is part of the aion network project.
* This file is part of the aion network project.

This comment has been minimized.

Copy link
@AlexandraRoatis

AlexandraRoatis Oct 2, 2018

Contributor

The license got formatted incorrectly. Please replace it with the second license from https://github.com/aionnetwork/aion/wiki/Aion-License-Header

Show resolved Hide resolved modApiServer/src/org/aion/api/server/types/TxRecptLg.java

@AionJayT AionJayT merged commit ae414e7 into master-pre-merge Oct 9, 2018

1 check passed

continuous-integration/jenkins/pr-merge This commit looks good
Details

@AionJayT AionJayT deleted the fix-TxReLog branch Oct 12, 2018

@iamyulong iamyulong referenced this pull request Nov 21, 2018

Closed

Empty address in log #717

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.