Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR690 redo #707

Merged
merged 72 commits into from Nov 23, 2018

Conversation

@AionJayT
Copy link
Collaborator

commented Nov 14, 2018

Notice

It is not allowed to submit your PR to the master branch directly, please submit your PR to the master-pre-merge branch.

Description

Resubmit PR for the PR #690 cause the branch was messed up.
this PR implemented the AIP006, AIP007 and merged ED25519 signature verify using precompiled contract.

Type of change

Insert x into the following checkboxes to confirm (eg. [x]):

  • Bug fix.
  • New feature.
  • Enhancement.
  • [ x Unit test.
  • [ x Breaking change (a fix or feature that causes existing functionality to not work as expected).
  • Requires documentation update.

Testing

Please describe the tests you used to validate this pull request. Provide any relevant details for test configurations as well as any instructions to reproduce these results.

Merged #701 into this PR as the testing case.

Verification

Insert x into the following checkboxes to confirm (eg. [x]):

  • I have self-reviewed my own code and conformed to the style guidelines of this project.
  • New and existing tests pass locally with my changes.
  • I have added tests for my fix or feature.
  • I have made appropriate changes to the corresponding documentation.
  • My code generates no new warnings.
  • Any dependent changes have been made.

@AionJayT AionJayT added the feature label Nov 14, 2018

@AionJayT AionJayT added this to the 0.3.2 milestone Nov 14, 2018

@@ -283,18 +282,11 @@ task pack(type: Tar) {
from "${dirPack}/rt"
include '**'
}
into('/aion/web3') {
into('/aion/console') {

This comment has been minimized.

Copy link
@AlexandraRoatis

AlexandraRoatis Nov 22, 2018

Contributor

Can we find another name for this folder? console has a common prefix with config leading to a lot of frustrations when trying to auto-complete with tab in the terminal. Perhaps web-console?

AionJayT added some commits Nov 22, 2018

Merge pull request #719 from aionnetwork/yulong
Move modBoost/resource to config

@AionJayT AionJayT merged commit e74a3af into master-pre-merge Nov 23, 2018

@AionJayT AionJayT deleted the AIP_redo branch Dec 11, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.