Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Step 5: kernel integration (database put/delete separation + Address interface) #782

Merged
merged 7 commits into from Jan 28, 2019

Conversation

Projects
None yet
4 participants
@aionick
Copy link
Collaborator

commented Jan 18, 2019

Step 5 in the integration.

This PR is concerned with:

  1. Key-value pairs are no longer interpreted as deleted when zero-byte array values, empty byte arrays or null values are provided. The delete functionality is moved out into its own method that must be called explicitly so that zero-byte arrays can be inserted into the database as values.
  2. The use of the Address interface replaces the AionAddress implementation where possible.

Required submodule updates:

@aionick aionick added the wip label Jan 18, 2019

@aionick aionick added this to the 0.3.3 milestone Jan 18, 2019

@AlexandraRoatis

This comment has been minimized.

Copy link
Contributor

commented Jan 18, 2019

will reopen after rebase

@AlexandraRoatis AlexandraRoatis force-pushed the incremental-pr5 branch from 09f2cc8 to 006fa4a Jan 23, 2019

@AlexandraRoatis AlexandraRoatis changed the base branch from incremental-pr3 to master-pre-merge Jan 23, 2019

@AlexandraRoatis AlexandraRoatis changed the title Step 5: kernel integration (database) Step 5: kernel integration (database put/delete separation + Address interface) Jan 23, 2019

@AlexandraRoatis AlexandraRoatis removed the wip label Jan 23, 2019

@AlexandraRoatis AlexandraRoatis force-pushed the incremental-pr5 branch from 006fa4a to de932d9 Jan 23, 2019

@AionJayT
Copy link
Collaborator

left a comment

Didn't see big issues. Waiting for other reviewer's comments.

@aion-kelvin
Copy link
Collaborator

left a comment

hey, looks good overall, just had a few small questions

@AlexandraRoatis AlexandraRoatis removed their request for review Jan 24, 2019

@AlexandraRoatis AlexandraRoatis self-assigned this Jan 24, 2019

@AlexandraRoatis AlexandraRoatis added the wip label Jan 25, 2019

@AlexandraRoatis AlexandraRoatis force-pushed the incremental-pr5 branch from 014fc25 to 4ab5bf2 Jan 28, 2019

@AlexandraRoatis AlexandraRoatis force-pushed the incremental-pr5 branch from 4ab5bf2 to 8af64ea Jan 28, 2019

@AlexandraRoatis AlexandraRoatis removed the wip label Jan 28, 2019

@AlexandraRoatis

This comment has been minimized.

Copy link
Contributor

commented Jan 28, 2019

I removed the contract details put/remove changes from this PR.

@AlexandraRoatis AlexandraRoatis force-pushed the incremental-pr5 branch from ee043aa to 25c4bb4 Jan 28, 2019

@AionJayT AionJayT merged commit 9c1d35b into master-pre-merge Jan 28, 2019

1 check passed

continuous-integration/jenkins/pr-merge This commit looks good
Details

@AlexandraRoatis AlexandraRoatis deleted the incremental-pr5 branch Jan 29, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.