Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Step 8: kernel integration (CLI for avmtestnet + config to disable AVM use) #791

Merged
merged 8 commits into from Jan 30, 2019

Conversation

Projects
None yet
5 participants
@AlexandraRoatis
Copy link
Contributor

commented Jan 21, 2019

Step 6 in the integration.

This PR is concerned with adding the necessary configuration for:

  1. running the kernel on the avmtestnet;
  2. disabling AVM functionality on the production networks.

Requires a rebase after Step 5 is merged.

@AlexandraRoatis AlexandraRoatis added the wip label Jan 21, 2019

@AlexandraRoatis AlexandraRoatis force-pushed the avmtestnet branch from e019045 to c1e9a4a Jan 23, 2019

@AlexandraRoatis AlexandraRoatis force-pushed the avmtestnet branch 5 times, most recently from 3924c68 to f691eb6 Jan 23, 2019

@aionick aionick changed the title Step 6: kernel integration (CLI for avmtestnet + config to disable AVM use) Step 8: kernel integration (CLI for avmtestnet + config to disable AVM use) Jan 28, 2019

@aionick aionick changed the title Step 8: kernel integration (CLI for avmtestnet + config to disable AVM use) Step 9: kernel integration (CLI for avmtestnet + config to disable AVM use) Jan 29, 2019

// add put and delete operations to batch
for (Map.Entry<byte[], byte[]> e : input.entrySet()) {
byte[] key = e.getKey();
byte[] value = e.getValue();

This comment has been minimized.

Copy link
@AionJayT

AionJayT Jan 29, 2019

Collaborator

can we just assign the return value into the following method?

This comment has been minimized.

Copy link
@AionJayT

AionJayT Jan 29, 2019

Collaborator

to avoid the local variable creating increase the heap size and the GC

This comment has been minimized.

Copy link
@AlexandraRoatis

AlexandraRoatis Jan 29, 2019

Author Contributor

this was also already included in #782

This comment has been minimized.

Copy link
@AionJayT

AionJayT Jan 29, 2019

Collaborator

just not sure does

                byte[] key = e.getKey();
                byte[] value = e.getValue();
                batch.put(key, value);

has any overhead during the runtime?
does this has same memory usage and performance as just using

batch.put(e.getKey(), e.getValue);
@AionJayT
Copy link
Collaborator

left a comment

Overall LGTM,
About the genesis file, who will manage the key of the preallocated accounts?

@AlexandraRoatis AlexandraRoatis self-assigned this Jan 29, 2019

@AlexandraRoatis AlexandraRoatis added this to the 0.3.3 milestone Jan 29, 2019

@AlexandraRoatis AlexandraRoatis force-pushed the avmtestnet branch from f691eb6 to 2a50a9c Jan 29, 2019

@AlexandraRoatis AlexandraRoatis removed the wip label Jan 29, 2019

@AlexandraRoatis AlexandraRoatis requested review from aion-kelvin and aionick Jan 29, 2019

@AlexandraRoatis AlexandraRoatis force-pushed the avmtestnet branch from 2a50a9c to 9a30633 Jan 29, 2019

@AlexandraRoatis AlexandraRoatis force-pushed the avmtestnet branch from 9a30633 to ba354d9 Jan 30, 2019

@AlexandraRoatis AlexandraRoatis changed the title Step 9: kernel integration (CLI for avmtestnet + config to disable AVM use) Step 8: kernel integration (CLI for avmtestnet + config to disable AVM use) Jan 30, 2019

@@ -11,6 +11,7 @@
MAINNET("mainnet", 256),
CONQUEST("conquest", 128),
MASTERY("mastery", 32),
AVMTESTNET("avmtestnet", 31), // temporary chainid

This comment has been minimized.

Copy link
@aion-kelvin

aion-kelvin Jan 30, 2019

Collaborator

is it still tempoary?

This comment has been minimized.

Copy link
@AlexandraRoatis

AlexandraRoatis Jan 30, 2019

Author Contributor

yeah, changing the chain id is something that may still happen

@AlexandraRoatis AlexandraRoatis merged commit bcead80 into master-pre-merge Jan 30, 2019

1 check passed

continuous-integration/jenkins/pr-merge This commit looks good
Details

@AlexandraRoatis AlexandraRoatis deleted the avmtestnet branch Jan 30, 2019

@AlexandraRoatis AlexandraRoatis restored the avmtestnet branch Jan 30, 2019

@AlexandraRoatis AlexandraRoatis deleted the avmtestnet branch Jan 30, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.