Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor enhancements to stats and kernel use #836

Merged
merged 4 commits into from Feb 22, 2019

Conversation

Projects
None yet
2 participants
@AlexandraRoatis
Copy link
Contributor

commented Feb 22, 2019

Description

This PR solves several issues:

  1. Bug fix: The number of peers stored when gathering stats is bounded using an LRU map.
  2. Fixes issue #825 by switching from using long to int in the maps used by the stats.
  3. A minor refactoring makes it more clear that division by zero is not possible in computing the percentages of requests made to peers.
  4. Changing the default config for performing integrity checks.

Type of change

Insert x into the following checkboxes to confirm (eg. [x]):

  • Bug fix.
  • New feature.
  • Enhancement.
  • Unit test.
  • Breaking change (a fix or feature that causes existing functionality to not work as expected).
  • Requires documentation update.

Testing

Please describe the tests you used to validate this pull request. Provide any relevant details for test configurations as well as any instructions to reproduce these results.

  • existing tests

Verification

Insert x into the following checkboxes to confirm (eg. [x]):

  • I have self-reviewed my own code and conformed to the style guidelines of this project.
  • New and existing tests pass locally with my changes.
  • I have added tests for my fix or feature.
  • I have made appropriate changes to the corresponding documentation.
  • My code generates no new warnings.
  • Any dependent changes have been made.

@AlexandraRoatis AlexandraRoatis added this to the 0.3.3 milestone Feb 22, 2019

@AlexandraRoatis AlexandraRoatis self-assigned this Feb 22, 2019

@AlexandraRoatis AlexandraRoatis requested review from arajasek and AionJayT Feb 22, 2019

@AlexandraRoatis AlexandraRoatis merged commit 62aa0b4 into master-pre-merge Feb 22, 2019

1 check passed

continuous-integration/jenkins/pr-merge This commit looks good
Details

@AlexandraRoatis AlexandraRoatis deleted the stats-lru branch Feb 22, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.