Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug fix: using the repositoryChild to check for used VM #855

Merged
merged 2 commits into from Mar 21, 2019

Conversation

Projects
None yet
2 participants
@AlexandraRoatis
Copy link
Contributor

commented Mar 21, 2019

Description

Bug fix: Replaced the use of the repository (which can be null) in the BulkExecutor with the repositoryChild.
Unit tests: Added tests for the pending state implementation (which instantiates the BulkExecutor with null repository) to expose incorrect calls to the repository in the future.

Type of change

Insert x into the following checkboxes to confirm (eg. [x]):

  • Bug fix.
  • New feature.
  • Enhancement.
  • Unit test.
  • Breaking change (a fix or feature that causes existing functionality to not work as expected).
  • Requires documentation update.

Testing

Please describe the tests you used to validate this pull request. Provide any relevant details for test configurations as well as any instructions to reproduce these results.

  • already existing tests
  • two additional tests for adding transactions to the pending state

Verification

Insert x into the following checkboxes to confirm (eg. [x]):

  • I have self-reviewed my own code and conformed to the style guidelines of this project.
  • New and existing tests pass locally with my changes.
  • I have added tests for my fix or feature.
  • I have made appropriate changes to the corresponding documentation.
  • My code generates no new warnings.
  • Any dependent changes have been made.

AlexandraRoatis added some commits Mar 21, 2019

@AlexandraRoatis AlexandraRoatis added this to the 0.4.0 milestone Mar 21, 2019

@AlexandraRoatis AlexandraRoatis self-assigned this Mar 21, 2019

@AlexandraRoatis AlexandraRoatis requested review from arajasek and AionJayT Mar 21, 2019

@AionJayT
Copy link
Collaborator

left a comment

LGTM

@AionJayT AionJayT merged commit 2b933db into master-pre-merge Mar 21, 2019

2 checks passed

continuous-integration/jenkins/branch This commit looks good
Details
continuous-integration/jenkins/pr-merge This commit looks good
Details

@AlexandraRoatis AlexandraRoatis deleted the repo-fix branch Mar 21, 2019

@AionJayT AionJayT modified the milestones: 0.4.0, 0.3.4 Apr 2, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.