New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added: `:` to start Command Palette Support #199

Merged
merged 5 commits into from May 23, 2018

Conversation

Projects
None yet
2 participants
@Molunerfinn
Contributor

Molunerfinn commented May 18, 2018

After reading the source code of the project and the VSCodeVim, I try to add : to start Command Palette Support.

Now I have finished some of the vim commands in Command Palette:

const commandParsers = {
    w: WriteCommand,
    write: WriteCommand,
    wa: WallCommand,
    wall: WallCommand,

    q: QuitCommand,
    quit: QuitCommand,
    qa: QuitAllCommand,
    qall: QuitAllCommand,

    wq: WriteQuitCommand,
    x: WriteQuitCommand,

    wqa: WriteQuitAllCommand,
    wqall: WriteQuitAllCommand,
    xa: WriteQuitAllCommand,
    xall: WriteQuitAllCommand,

    vs: VisualSplitCommand,
    vsp: VisualSplitCommand,

    new: NewFileCommand,
    vne: VerticalNewFileCommand,
    vnew: VerticalNewFileCommand
};

Here are some screenshots:

  1. in normal mode type : :
    tostartpalette
  2. :wq
    wq
  3. :vs
    vs
  4. :new
    new
  5. of course, go to line is also supported:
    gotoline

I hope that my contribution can help you! If you think it can be merged, you can remove the line in your readme:

image

Thank you for your nice project!

@Molunerfinn Molunerfinn changed the title from Added: `:` to started Command Palette Support to Added: `:` to start Command Palette Support May 19, 2018

@aioutecism

Cloud you lint the code with tslint?
I'm noticing a lot missing semicolons. They won't hurt much but let's follow the good practice.

Show outdated Hide outdated src/Actions/Command.ts
Show outdated Hide outdated src/CommandLine/CommandLine.ts
Show outdated Hide outdated src/CommandLine/CommandLine.ts
Show outdated Hide outdated src/Modes/Normal.ts
Show outdated Hide outdated src/CommandLine/Commands/Base.ts
Show outdated Hide outdated src/CommandLine/Parser.ts
Show outdated Hide outdated src/CommandLine/Parser.ts
Show outdated Hide outdated src/CommandLine/Parser.ts
Show outdated Hide outdated src/CommandLine/Parser.ts
Show outdated Hide outdated src/CommandLine/Parser.ts
@aioutecism

Cloud you lint the code with tslint?
I'm noticing a lot missing semicolons. They won't hurt much but let's follow the good practice.

@Molunerfinn

This comment has been minimized.

Show comment
Hide comment
@Molunerfinn

Molunerfinn May 22, 2018

Contributor

Thanks for the reply! I'll fix them ASAP.

Contributor

Molunerfinn commented May 22, 2018

Thanks for the reply! I'll fix them ASAP.

@Molunerfinn

This comment has been minimized.

Show comment
Hide comment
@Molunerfinn

Molunerfinn May 22, 2018

Contributor

All the new files have been tested by tslint 😁~

Contributor

Molunerfinn commented May 22, 2018

All the new files have been tested by tslint 😁~

@aioutecism

Thank you for the fixes!

@Molunerfinn

This comment has been minimized.

Show comment
Hide comment
@Molunerfinn

Molunerfinn May 23, 2018

Contributor

I can fix above now, just wait for a moment~

Contributor

Molunerfinn commented May 23, 2018

I can fix above now, just wait for a moment~

@Molunerfinn

This comment has been minimized.

Show comment
Hide comment
@Molunerfinn

Molunerfinn May 23, 2018

Contributor

Done 😀

Contributor

Molunerfinn commented May 23, 2018

Done 😀

@aioutecism aioutecism merged commit 8173e96 into aioutecism:master May 23, 2018

@aioutecism

This comment has been minimized.

Show comment
Hide comment
@aioutecism

aioutecism May 23, 2018

Owner

Thank you for your contribution!
I'll do some cleanup and then publish a new version soon.

Owner

aioutecism commented May 23, 2018

Thank you for your contribution!
I'll do some cleanup and then publish a new version soon.

@Molunerfinn

This comment has been minimized.

Show comment
Hide comment
@Molunerfinn

Molunerfinn May 23, 2018

Contributor

Can't wait for it! Thank you for your nice job!

Contributor

Molunerfinn commented May 23, 2018

Can't wait for it! Thank you for your nice job!

@Molunerfinn

This comment has been minimized.

Show comment
Hide comment
@Molunerfinn

Molunerfinn May 23, 2018

Contributor

@aioutecism I think you can change the README:

👍

Contributor

Molunerfinn commented May 23, 2018

@aioutecism I think you can change the README:

👍

@aioutecism

This comment has been minimized.

Show comment
Hide comment
@aioutecism

aioutecism May 23, 2018

Owner

Published 1.26.1.
Readme is updated too.

Owner

aioutecism commented May 23, 2018

Published 1.26.1.
Readme is updated too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment