Added: `:` to start Command Palette Support by Molunerfinn · Pull Request #199 · aioutecism/amVim-for-VSCode

Molunerfinn · 2018-05-18T15:04:47Z

After reading the source code of the project and the VSCodeVim, I try to add : to start Command Palette Support.

Now I have finished some of the vim commands in Command Palette:

const commandParsers = {
    w: WriteCommand,
    write: WriteCommand,
    wa: WallCommand,
    wall: WallCommand,

    q: QuitCommand,
    quit: QuitCommand,
    qa: QuitAllCommand,
    qall: QuitAllCommand,

    wq: WriteQuitCommand,
    x: WriteQuitCommand,

    wqa: WriteQuitAllCommand,
    wqall: WriteQuitAllCommand,
    xa: WriteQuitAllCommand,
    xall: WriteQuitAllCommand,

    vs: VisualSplitCommand,
    vsp: VisualSplitCommand,

    new: NewFileCommand,
    vne: VerticalNewFileCommand,
    vnew: VerticalNewFileCommand
};

Here are some screenshots:

in normal mode type : :
:wq
:vs
:new
of course, go to line is also supported:

I hope that my contribution can help you! If you think it can be merged, you can remove the line in your readme:

Thank you for your nice project!

aioutecism

Cloud you lint the code with tslint?
I'm noticing a lot missing semicolons. They won't hurt much but let's follow the good practice.

aioutecism · 2018-05-22T08:40:01Z

-        return commands.executeCommand('workbench.action.gotoLine');
+    static async command(): Promise<void> {
+        // this is undefined
+        return await CommandLine.PromptAndRun();


This seems redundant.

Shall we move src/CommandLine/ to src/Actions/CommandLine/ and use it directly like this?

{ keys: ':', actions: [ActionCommandLine.prompt] }

aioutecism · 2018-05-22T08:42:22Z

+      if (!vscode.window.activeTextEditor) {
+          return
+      }
+      let text = ''


The variable is never used.

aioutecism · 2018-05-22T08:43:09Z

+          }
+          return await CommandLine.Run(cmd);
+      } catch (e) {
+          console.log(e)


Shall we use console.error to indicate that something went wrong?

aioutecism · 2018-05-22T08:46:00Z

        { keys: 'z R', actions: [ActionFold.unfoldAll] },

-        { keys: ':', actions: [ActionCommand.goToLine] },
+        // { keys: ':', actions: [ActionCommand.goToLine] },


We can just delete lines we don't need in the future.

aioutecism · 2018-05-22T08:46:49Z

@@ -0,0 +1,4 @@
+export abstract class CommandBase {
+  protected name: string;


I don't see the use of name anywhere in this Pull Request.
Is it necessary?

It's not necessary 😂

aioutecism · 2018-05-22T08:59:32Z

+    qall: QuitAllCommand,
+
+    wq: WriteQuitCommand,
+    writequit: WriteQuitCommand,


writequit is not a Vim command.

Oh, my fault

Don't mind. I like the idea though 😄.

aioutecism · 2018-05-22T09:02:16Z

+    vs: VisualSplitCommand,
+    vsp: VisualSplitCommand,
+    sp: VisualSplitCommand,
+    split: VisualSplitCommand,


sp and split are for the horizontal split. VSCode doesn't support this right now.

VSCode should support horizontal split now

aioutecism · 2018-05-22T09:03:26Z

+    sp: VisualSplitCommand,
+    split: VisualSplitCommand,
+    vsplit: VisualSplitCommand,
+    ne: NewFileCommand,


ne is for editing next file.

aioutecism · 2018-05-22T09:04:56Z

+    ne: NewFileCommand,
+    vne: NewFileCommand,
+    new: NewFileCommand,
+    vnew: NewFileCommand


vne and vnew should create the new file in a vertically split pane.

aioutecism · 2018-05-22T09:05:44Z

+export function parser(input: string): CommandBase | undefined {
+    if (commandParsers[input]) {
+        return commandParsers[input]
+    } else if (isNumber(input)) {


I think we should use Number.isInteger here.

The type of input is string, so if you just use Number.isInteger(input) will get false. While I can add it in the isNumber function to detect if the input is an interger

aioutecism

Cloud you lint the code with tslint?
I'm noticing a lot missing semicolons. They won't hurt much but let's follow the good practice.

Molunerfinn · 2018-05-22T11:16:00Z

Thanks for the reply! I'll fix them ASAP.

Molunerfinn · 2018-05-22T12:49:19Z

All the new files have been tested by tslint 😁~

aioutecism · 2018-05-23T05:25:27Z

+    const lineNumber = Number(line);
+    let editor = vscode.window.activeTextEditor;
+    if (editor) {
+      ActionMoveCursor.byMotions({


We should await this action.

aioutecism · 2018-05-23T05:26:32Z

+import * as vscode from 'vscode';
+import { CommandBase } from './Base';
+
+class QuitCommand extends CommandBase {


Shouldn't this be QuitAllCommand?

aioutecism · 2018-05-23T05:40:38Z

+  async execute(): Promise<void> {
+    await VisualSplit.execute();
+    await NewFile.execute();
+    await vscode.commands.executeCommand('workbench.action.closeOtherEditors');


This may have unwanted effects when we execute the command in the third column.
We can use workbench.action.files.newUntitledFile then workbench.action.moveEditorToNextGroup.

aioutecism · 2018-05-23T05:44:23Z

+import WriteAllCommand from './WriteAll';
+import QuitAllCommand from './QuitAll';
+
+class WriteQuitCommand extends CommandBase {


And this should be WriteQuitAllCommand.

aioutecism · 2018-05-23T05:47:28Z

+export function parser(input: string): CommandBase | undefined {
+    if (commandParsers[input]) {
+        return commandParsers[input];
+    } else if (isNumber(input)) {


Since this is a simple expression, we cloud use Number.isInteger(Number(input)) directly.

aioutecism

Thank you for the fixes!

Molunerfinn · 2018-05-23T05:55:07Z

I can fix above now, just wait for a moment~

Molunerfinn · 2018-05-23T06:04:42Z

Done 😀

aioutecism · 2018-05-23T06:12:20Z

Thank you for your contribution!
I'll do some cleanup and then publish a new version soon.

Molunerfinn · 2018-05-23T06:12:54Z

Can't wait for it! Thank you for your nice job!

Molunerfinn · 2018-05-23T08:31:02Z

@aioutecism I think you can change the README:

👍

aioutecism · 2018-05-23T08:35:41Z

Published 1.26.1.
Readme is updated too.

Molunerfinn added 3 commits May 18, 2018 21:42

Added: several commands support for Command Palette

f8f9af1

Added: newfile & visualsplit commands for Command Platte

d1aa8ff

Added: newfile & visualsplit commands for Command Platte

3511004

Molunerfinn changed the title ~~Added: : to started Command Palette Support~~ Added: : to start Command Palette Support May 19, 2018

aioutecism reviewed May 22, 2018

View reviewed changes

aioutecism assigned Molunerfinn May 22, 2018

aioutecism added the feature label May 22, 2018

Fixed: several bugs & added tslint for commandLine files

5c55d9d

aioutecism requested changes May 23, 2018

View reviewed changes

aioutecism reviewed May 23, 2018

View reviewed changes

Fixed: sevaral bugs in command line

1445790

aioutecism approved these changes May 23, 2018

View reviewed changes

aioutecism merged commit 8173e96 into aioutecism:master May 23, 2018

		@@ -0,0 +1,4 @@
		export abstract class CommandBase {
		protected name: string;

Conversation

Molunerfinn commented May 18, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

aioutecism left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

aioutecism left a comment

Choose a reason for hiding this comment

Uh oh!

Molunerfinn commented May 22, 2018

Uh oh!

Molunerfinn commented May 22, 2018

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

aioutecism left a comment

Choose a reason for hiding this comment

Uh oh!

Molunerfinn commented May 23, 2018

Uh oh!

Molunerfinn commented May 23, 2018

Uh oh!

aioutecism commented May 23, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Molunerfinn commented May 23, 2018

Uh oh!

Molunerfinn commented May 23, 2018

Uh oh!

aioutecism commented May 23, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Molunerfinn commented May 18, 2018 •

edited

Loading

aioutecism commented May 23, 2018 •

edited

Loading