Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(AIP-8): clarify clients AIPs should benefit #1114

Merged
merged 10 commits into from
Jul 14, 2023

Conversation

toumorokoshi
Copy link
Contributor

Without clear guidance on the types of clients AIPs should benefit, it is unclear to an AIP author what the criteria of a good AIP is.

This clarifies the guidance, and implicitly expand the scope of AIPs beneficiaries from just end-users to all clients that user may use to interact with the API.

Without clear guidance on the types of clients AIPs should
benefit, it is unclear to an AIP author what the criteria of
a good AIP is.

This clarifies the guidance, and implicitly expand the
scope of AIPs beneficiaries from just end-users to all
clients that user may use to interact with the API.
@toumorokoshi toumorokoshi requested a review from a team as a code owner May 21, 2023 04:31
aip/general/0008.md Show resolved Hide resolved
aip/general/0008.md Outdated Show resolved Hide resolved
aip/general/0008.md Show resolved Hide resolved
aip/general/0008.md Outdated Show resolved Hide resolved
aip/general/0008.md Outdated Show resolved Hide resolved
aip/general/0008.md Outdated Show resolved Hide resolved
aip/general/0008.md Outdated Show resolved Hide resolved
aip/general/0008.md Outdated Show resolved Hide resolved
- consolidating the list of clients to a single location.
- adding more lists of clients.
Copy link
Contributor

@bgrant0607 bgrant0607 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few typos and one significant comment, regarding implementation difficulty.

aip/general/0008.md Outdated Show resolved Hide resolved
aip/general/0008.md Outdated Show resolved Hide resolved
aip/general/0008.md Outdated Show resolved Hide resolved
- fixing typos and grammar
@toumorokoshi
Copy link
Contributor Author

Thanks @bgrant0607 ! ready for another review.

@noahdietz I added you as a second reviewer as well, if you could TAL.

Copy link
Contributor

@bgrant0607 bgrant0607 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the updates.

aip/general/0008.md Outdated Show resolved Hide resolved
@toumorokoshi toumorokoshi merged commit ff1ad3a into aip-dev:master Jul 14, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants