Skip to content

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also compare across forks.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also compare across forks.
...
This comparison is big! We’re only showing the most recent 250 commits
Commits on Jun 24, 2015
@batter batter Merge pull request #554 from tobytripp/tobytripp-specified-load-order
Specify load order in active_record.rb to ensure VersionAssociation is loaded before Version
8596968
@batter batter Ensure the default serializer is loaded to memory before referencing …
…it in PaperTrail::Config#initialize [ci skip]
797057b
Commits on Jun 25, 2015
@batter batter Merge pull request #551 from airblade/fix_mysql_text_too_short
In MySQL, use longtext instead of text
30a9d18
Commits on Jun 27, 2015
@jaredbeck jaredbeck Docs: Modern AR find coerces to int if necessary
From the AR docs:

> If the primary key is an integer, find .. coerces its arguments using to_i.
> http://bit.ly/1NltoaC

So, our advice to use to_i manually is no longer necessary.

[ci skip]
fc9244d
@jaredbeck jaredbeck Docs: Add ToC to readme
[ci skip]
e19c4b7
@jaredbeck jaredbeck Docs: bibliography syntax for links
When reading markdown source, long links can make paragraphs
harder to read, so I prefer to use the "bibliography" syntax
within paragraphs.  It also enables URL reuse.

[ci skip]
00c2da3
@jaredbeck jaredbeck Docs: Break long lines
- While modern versions of command-line git present long lines
  well in a diff, github does not.
- Also, many people do not configure their editor to soft wrap
  long lines.

[ci skip]
c9db0fc
@jaredbeck jaredbeck Docs: Remove unusual "chevron" prefix in code samples
Perhaps the intention of the prefix was to indicate logical lines
of code, but I don't think that's necessary.

[ci skip]
d276fd6
@jaredbeck jaredbeck Docs: Move RailsCast link to articles list
There is already a link under "Reverting And Undeleting A Model"

[ci skip]
d3be90a
@jaredbeck jaredbeck Docs: Limiting the Number of Versions Created
- The terminology of "Object Instance" here is misleading.
  Conceptually, it is the record in the database which is tracked,
  not the instance of the ruby object in memory.  In fact, there
  may be multiple instances of the record in memory, e.g. in a
  multi-threaded server.
- Also, we can't list all of the reasons someone might want to
  configure a limit.  A readme should be concise.

[ci skip]
008dad3
Commits on Jun 28, 2015
@jaredbeck jaredbeck Docs: Distinction between changes and enhancements
[ci skip]
8be903b
Commits on Jun 29, 2015
@jaredbeck jaredbeck Do not recommend initializer
An alternative to #492

[ci skip]
e472b7b
@jaredbeck jaredbeck Merge pull request #557 from airblade/do_not_recommend_initializer
Docs: Do not recommend initializer
491b15f
Commits on Jul 02, 2015
@tobypinder tobypinder Document limitations of `class_name`
Make it clear that PaperTrail doesn't currently support relative `class_name`s for modules - an absolute module path is required. See #558
d03767e
@jaredbeck jaredbeck Docs: Break long lines [ci skip] c003ae9
@jaredbeck jaredbeck Add test demonstrating namespace
Demonstrates changes to docs in
#559
758e7e4
@jaredbeck jaredbeck Merge pull request #559 from tobypinder/patch-1
Document limitations of `class_name`
724eeae
@jaredbeck jaredbeck Merge pull request #561 from airblade/testing_module_namespace
Add test demonstrating namespace
3d6d796
Commits on Jul 09, 2015
@jaredbeck jaredbeck Fixes `touch_with_version` re: the `:on` option
Fixes a bug where e.g. `on: [:create, :destroy]` (not :update)
failed to create a version.
0fd007c
@batter batter Merge pull request #563 from airblade/clarify_touch_with_version
Fixes `touch_with_version` re: the `:on` option
cc3f639
@batter batter Update CHANGELOG regarding #563; [ci skip] c639fd1
@batter batter RM unused javascripts directory from the Dummy test app bf4cf9c
@batter batter RM whole public dir from the dummy app since it's not necessary for t…
…esting
5be9181
Commits on Jul 13, 2015
@jaredbeck jaredbeck Docs: Move console whodunnit example to wiki
The readme is quite long already, and this example will not be useful
to most people. Also, this example recommends an initializer, a
technique that we no longer recommend.

[ci skip]
5a03a1b
@jaredbeck jaredbeck Docs: Rails initializer is no longer recommended
[ci skip]
71453f3
@jaredbeck jaredbeck Docs: Classify as change, not enhancement
[ci skip]
36d5b44
@jaredbeck jaredbeck Docs: List bug fixes separately from new features
[ci skip]
234d003
@jaredbeck jaredbeck Docs: Classify issue 248 as fixed, not added
Given that this fixes an uncommon error, and will have little
impact on new or existing apps, I prefer to classify this as
a bug fix.

[ci skip]
4ed899a
@jaredbeck jaredbeck Docs: Break long lines
[ci skip]
c60e124
@jaredbeck jaredbeck Fix incorrect deprecation message
We just deprecated this method in 4.0, right? So, we can't also
remove it in 4.0, or any 4.x for that matter. We either deprecate
or remove, and I don't care which, but we can't do both in the
same major version. :)

[ci skip]
c0348a7
@jaredbeck jaredbeck Use ActiveSupport::Deprecation.warn, not Kernel#warn
- Provides helpful stack trace
- Can be silenced
- We already have a dependency on activesupport
- Available in all versions of rails we support: 3 - 5
748226b
@jaredbeck jaredbeck Fully-qualify ::ActiveSupport::Deprecation constant
> .. just in case we later add an ActiveSupport module within the gem.
> https://github.com/airblade/paper_trail/pull/567/files#r34470343
c9406c0
Commits on Jul 14, 2015
@jaredbeck jaredbeck Merge pull request #567 from airblade/various_doc_updates
Various doc updates
5bad080
Commits on Jul 16, 2015
@jaredbeck jaredbeck Respect `:skip` re: timestamp-only updates
When attributes are ignored, either by `:ignore` or by `:skip`,
then during updates, timestamp attributes like `updated_at` should
not be considered notable changes.

[Fixes #569]
40bf20b
Commits on Jul 17, 2015
@jaredbeck jaredbeck Merge pull request #570 from airblade/issue_569_notable_updated_at
Respect `:skip` re: timestamp-only updates
cda10ba
@jaredbeck jaredbeck Relax version constraint on request_store
.. to allow request_store 1.2.

AFAICT they don't have a changelog, so we have to review commits:

https://github.com/steveklabnik/request_store/commits/master

The only new feature appears to be:

steveklabnik/request_store#37
d4a418f
@jaredbeck jaredbeck Merge pull request #571 from airblade/allow_request_store_1.2
Relax version constraint on request_store
64cdbd1
Commits on Jul 20, 2015
@batter batter Bump version number to 4.0.0.rc2 [ci skip] cd46158
Commits on Jul 23, 2015
@batter batter close #534; Don't attempt to load models via a Rails::Engine in Rails…
… versions less than 3.2
cb10579
Commits on Jul 29, 2015
@jaredbeck jaredbeck Organize the 4.0 release notes
Distinguishing changes, additions, and fixes helps users to upgrade.

[ci skip]
a4d543b
@jaredbeck jaredbeck Merge pull request #577 from airblade/organize_4.0_changelog
Docs: Organize the 4.0 release notes
d0a4a3d
@jaredbeck jaredbeck Remove deprecated: paper_trail_on, paper_trail_off
4395a30
Commits on Jul 30, 2015
@batter batter Update Changelog release notes for 4.0 to contain a 'Removed' section
b18f186
@batter batter Update CHANGELOG regarding removal of non bang on/off methods so the …
…linked PR # is correct [ci skip]
374f508
@batter batter close #566; Merge branch 'remove_deprecated_non_bang' [ci skip] bba433a
@batter batter Bump to 4.0.0 [ci skip] f3b31fa
Commits on Aug 03, 2015
Moritz Kröger Possibility to preserve skipped attributes on reify 4db87df
@jaredbeck jaredbeck Merge pull request #579 from McRip/preserve_skipped_attributes_on_reify
Possibility to preserve skipped attributes on reify
239db43
@jaredbeck jaredbeck Update changelog re: #579
[ci skip]
676f273
@jaredbeck jaredbeck Organize 4.0.0 change list
Keeping all changes in a single list means users only have to look
in one place when they upgrade.

In this case, the "Removed" item was really obvious, but in general
a single list is a good practice, I think.

A single list is also recommended by http://keepachangelog.com/
which I'm a big fan of.

[ci skip]
c825932
@jaredbeck jaredbeck Format comments
- Wrap comments at 80 chars
- Fix English grammar
  - Start sentances with capital letters
  - End sentances with a period
- Use markdown for lists, e.g. method arguments

[ci skip]
68a0ab7
@batter batter Merge pull request #580 from airblade/removed_is_changed
Organize 4.0.0 change list
bdcd1f9
@jaredbeck jaredbeck Merge pull request #582 from airblade/formatting_comments
Format comments
b5c2bce
Commits on Aug 06, 2015
@jaredbeck jaredbeck Docs: Move badges out of h1
Fixes giant img alt text when badge images are not available.

[ci skip]
b389c94
@jaredbeck jaredbeck Docs: Organize readme re: limiting what/when
Group together readme sections about limiting what is versioned,
and when.

[ci skip]
b7dc57c
@jaredbeck jaredbeck Docs: Organize compatibility info into a table
[ci skip]
b6070c4
@jaredbeck jaredbeck Docs: Organize the feature list
It's still too long for my taste, but this way people can just
scan the top-level bullet points.

[ci skip]
d8651f2
@jaredbeck jaredbeck Docs: Organize readme re: Working with versions
[ci skip]
a6aeb6e
@jaredbeck jaredbeck Docs: A more concise intro paragraph
[ci skip]
af81547
Commits on Aug 07, 2015
@jaredbeck jaredbeck Merge pull request #586 from airblade/various_readme_changes
Various readme changes
520f64b
Commits on Aug 10, 2015
@jaredbeck jaredbeck Docs: Update example of Diffing Versions
[ci skip]
7e7a349
Commits on Aug 11, 2015
@jaredbeck jaredbeck Docs: Update compatibility table
[ci skip]
87917e0
@ItaiLeibowitz ItaiLeibowitz Use updated_at timestamp for "create" versions
"Create" versions currently use the item's created_at field to set the version's timestamp. 

This is wrong in the case where the item was created at some point in the past, then deleted, then is now being created again (e.g., through reification). The version gets the timestamp from the original creation.

Instead, this change uses the item's updated_at field which is the time of the re-creation. This is also consistent with what happens in "update" versions
245e835
@batter batter Merge remote-tracking branch 'ItaiLeibowitz/create-timestamp-update' 4f1b2b6
Commits on Aug 12, 2015
@batter batter Update tests for PR #589 a53d6e4
@batter batter close #588; close #589; Update CHANGELOG 7d7af89
Commits on Aug 21, 2015
@jaredbeck jaredbeck Docs: Warn about known issues with associations
[ci skip]
ce37034
Commits on Aug 27, 2015
@batter batter Fix markdown for links that were inserted but broken in ce37034 5187a71
Commits on Aug 31, 2015
@jaredbeck jaredbeck Docs: Convert a column from text to json
In response to
#600
.  Maybe other people will have the same question.

[ci skip]
a1108a6
Commits on Sep 02, 2015
@jaredbeck jaredbeck Docs: Contributing guide, initial revision
[ci skip]
951a62b
Commits on Sep 03, 2015
@jaredbeck jaredbeck Control order of `set_paper_trail_whodunnit` callback
Fixes #301

Stop automatically adding the `set_paper_trail_whodunnit`
before_filter.  This gives people control over the order of this
callback.
6b43834
Commits on Sep 09, 2015
@jaredbeck jaredbeck Merge pull request #556 from airblade/set_paper_trail_whodunnit
Control the order of `set_paper_trail_whodunnit` callback
5add1e4
@jaredbeck jaredbeck Docs: Update compat. table
.. to reflect that master now represents 5.0

[ci skip]
767e835
@jaredbeck jaredbeck Temporarily constrain mysql2 gem to ~> 0.3.20
We would prefer to only constrain mysql2 to '~> 0.3',
but a rails bug (rails/rails#21544)
requires us to constrain to '~> 0.3.20' for now.
a97850a
@jaredbeck jaredbeck Also constrain mysql2 in the rails 3.0 gemfile
See previous commit.
69f9d3c
Commits on Sep 10, 2015
Ninigi added callback-methods 9008d67
Commits on Sep 11, 2015
@jaredbeck jaredbeck Warn about order of callbacks
Also, various minor formatting.

[ci skip]
64c4a5b
Commits on Sep 15, 2015
@theRealNG theRealNG support nested has_many through associations in #reify a660615
Ninigi legacy complient callback-methods 297f5fc
Commits on Sep 16, 2015
@jaredbeck jaredbeck Merge pull request #596 from theRealNG/issue#590
fix issue in #reify_has_many_through
364d04a
@jaredbeck jaredbeck Install debugger: pry
f5fe764
@jaredbeck jaredbeck Add comments in reify_has_many_through
0ce62f6
@jaredbeck jaredbeck Move associations tests to separate file
Because model_test.rb is too long, and it's misleading to define
multiple classes in such a long file.  It's easy to not notice
that there's a second class.

Also, clarify a few of the Has Many Through (HMT) tests

- Improve descriptions
- Decrease context nesting
- Prefer local variables over instance variables
- Name version variables more consistently
  - Use version numbers instead of `last`
ecf006b
@jaredbeck jaredbeck Stop testing against ruby 1.8
PaperTrail 5 will not support ruby 1.8
5dad0a5
@batter batter Merge pull request #617 from airblade/pry_debugger
Install debugger: pry
8645c92
Commits on Sep 22, 2015
Ninigi merge with original master baca9b0
Commits on Sep 23, 2015
Ninigi updated readme 02b1c09
Ninigi add callback_modifier to the down method d63eb4e
@jaredbeck jaredbeck Merge pull request #620 from airblade/drop_ruby_18_support
Stop testing against ruby 1.8
678be77
@jaredbeck jaredbeck Merge pull request #619 from airblade/move_assoc_tests
Move associations tests to separate file
8c42fb2
@jaredbeck jaredbeck Merge pull request #618 from airblade/comments_in_reify_hmt
Add comments in reify_has_many_through
1cb49a3
Ninigi removed cleanup callback chain 0f40d74
@batter batter Specify required ruby version of 1.9 or greater
52c9759
@jaredbeck jaredbeck Merge pull request #623 from airblade/drop_ruby18_support
Specify required ruby version of 1.9 or greater
71ba6d3
@jaredbeck jaredbeck Extract module: Reifier
This refactoring encapsulates the process of reification, separating
it from the model (VersionConcern).

The ABC complexity score of VersionConcern (measured by flog) is
reduced from 750 to 362, a 52% reduction.

Finally, this refactoring provides a truely private namespace for
methods like `reify_has_many_through`. Such methods will no
longer be mixed into PaperTrail::Version, or end-user's version
models, if any.
fbac7a6
Commits on Sep 28, 2015
@batter batter Merge pull request #583 from airblade/extract_reify
Extract functionality to module: Reifier
f64c4f3
Commits on Sep 30, 2015
@orthographic-pedant orthographic-pedant Fixed typographical error, changed abilty to ability in README. 32332fc
@batter batter Update CHANGELOG to point to PR #556 and issue #301 for corresponding…
… change
7890a83
@orthographic-pedant orthographic-pedant Fixed typographical error, changed aganist to against in README. 3a916bc
@jaredbeck jaredbeck Merge pull request #626 from orthographic-pedant/spell_check/against
Fixed typographical error, changed aganist to against in README.
43d0910
@jaredbeck jaredbeck Merge pull request #625 from orthographic-pedant/spell_check/ability
Fixed typographical error, changed abilty to ability in README.
ad1d1f1
@jaredbeck jaredbeck Docs: Update list of known issues with associations
[ci skip]
3ea9f6d
Commits on Oct 01, 2015
@heridev heridev Adds small note remembering the user to add new columns when using me…
…tadata
00c3ee8
@jaredbeck jaredbeck Merge pull request #628 from heridev/features/add-readme-note-about-a…
…dding-new-columns-metadata

Adds small note remembering the user to add new columns when using metadata
117288f
Commits on Oct 02, 2015
@jashank jashank Switch callbacks from `_filter` to `_action`
Rails 5, in rails/rails@7644a99, deprecated controller callbacks
suffixed `_filter` in favour of those suffixed `_action`.  However,
callbacks of the latter variety don't exist in Rails 3.2, so check if
they exist.
2c7416d
@jaredbeck jaredbeck Merge pull request #629 from jashank/master
Switch callbacks from `_filter` to `_action`
5a5ff94
Commits on Oct 08, 2015
@ihara2525 ihara2525 Fix typo in README 96f9880
@batter batter Merge pull request #630 from ihara2525/fix-typo-in-readme
Fix typo in README
d72aebe
@jaredbeck jaredbeck Extract private method: prepare_array_for_has_many
Reduce duplication between reify_has_many_directly and
reify_has_many_through.

This refactoring reduces the ABC complexity as follows:

Before
------

489.0: flog total
81.5: flog/method average
129.2: PaperTrail::Reifier::reify_has_many_through
114.9: PaperTrail::Reifier::reify_has_many_directly

After
-----

454.2: flog total
64.9: flog/method average
95.5: PaperTrail::Reifier::reify_has_many_through
81.5: PaperTrail::Reifier::reify_has_many_directly
8a331d3
@jaredbeck jaredbeck Merge pull request #631 from airblade/extract_array_method_in_reifier
Extract private method: prepare_array_for_has_many
5ac11e2
@jaredbeck jaredbeck Extract private method: versions_by_id
Reduce duplication between reify_has_many_directly and
reify_has_many_through.

This refactoring reduces the ABC complexity as follows:

Before
------

454.1: flog total
64.9: flog/method average
95.5: PaperTrail::Reifier::reify_has_many_through
81.5: PaperTrail::Reifier::reify_has_many_directly

After
-----

444.3: flog total
55.5: flog/method average
85.5: PaperTrail::Reifier::reify_has_many_through
71.6: PaperTrail::Reifier::reify_has_many_directly
36c1283
Commits on Oct 09, 2015
@jaredbeck jaredbeck Merge pull request #632 from airblade/extract_hash_method_in_reifier
Extract private method: versions_by_id
207d2f5
Ninigi updated README, set spec_helper back to original, append option to pa…
…per_trail_options[:on] when using callback-methods
8fe6ada
Commits on Oct 10, 2015
@jaredbeck jaredbeck Merge pull request #614 from Ninigi/master
Enable control over the order of AR callbacks
de52843
@jaredbeck jaredbeck Minor changes to docs, tests, for PR 614 05e21cc
Commits on Oct 14, 2015
@jaredbeck jaredbeck Remove travis ci badge which no longer works
It's still red, even though the build of master has been green for
more than 24 hours.
befd5af
@jaredbeck jaredbeck Fix travis ci badge by using master branch SVG
Explanation from María de Antón at Travis CI:

> The default badge image shows the latest build result
> (https://api.travis-ci.org/airblade/paper_trail.svg),
> which in this case is
> https://travis-ci.org/airblade/paper_trail/builds/84872354
> (from: https://travis-ci.org/airblade/paper_trail/builds)
>
> If you check master branch's badge, it's indeed green:
> https://api.travis-ci.org/airblade/paper_trail.svg?branch=master
> as its latest build.
36185ef
Commits on Oct 18, 2015
@jaredbeck jaredbeck Docs: Remove features list
It was redundant because the table of contents has basically
the same items.

[ci skip]
014628c
@jaredbeck jaredbeck Docs: Organizing table of contents
[ci skip]
e825211
@jaredbeck jaredbeck Docs: Move the Sinatra section to the bottom
[ci skip]
ecaf625
@jaredbeck jaredbeck Docs: Move "Basic Usage" above "API Summary"
The basics section is more friendly, and a better introduction,
so it should come first.

I'm not at all sure we should even keep the API summary. It would
be better to use something like RDoc for that.

[ci skip]
cd54593
@jaredbeck jaredbeck Docs: Update table of contents after organizing
[ci skip]
1c4d1dc
Commits on Oct 20, 2015
@jaredbeck jaredbeck Test data befitting of the crazy AssociationsTest d312d1f
@jaredbeck jaredbeck Code style: Prefer else to next in this case
bbe3094
@jaredbeck jaredbeck Merge pull request #637 from airblade/prepare_to_fix_633
Prepare to fix 633
b6be4af
Commits on Oct 31, 2015
@jaredbeck jaredbeck Docs: Contrib. guide, notes on testing
[ci skip]
4409559
Commits on Nov 01, 2015
@jaredbeck jaredbeck Docs: Contrib. guide: more testing notes
[ci skip]
8003115
@jaredbeck jaredbeck Update schema.rb re: chapters, sections, etc. a2ada6c
@jaredbeck jaredbeck Fix issue 633 re: reification of through assoc.
3279206
@jaredbeck jaredbeck Merge pull request #638 from airblade/fix_issue_633
Fix issue 633 re: reification of through assoc.
52745df
@jaredbeck jaredbeck Docs: Add warnings about time precision in MySQL
[ci skip]
1d120ab
@jaredbeck jaredbeck Docs: It's not a breaking change, it's a fix :)
The "changes" section of the release notes is for breaking
changes only. The purpose is so that people don't need to read
as much when upgrading, they can just read the changes section,
they don't need to read the full release notes.

Only major version bumps should have breaking changes.

[ci skip]
8402e1b
@jaredbeck jaredbeck In track_associations, only check db if no config
This allows users who need to precompile assets without a database
to configure `track_associations = false`.

See discussion: #636
90dc72c
Commits on Nov 02, 2015
@jaredbeck jaredbeck Use class inst. var. instead of class var.
I use the term "class instance variable" and "class variable"
even though `PaperTrail` is a module. This nomenclature is
conventional in ruby.

> module A; @@x = :x; puts defined?(@@x); end
> #=> "class variable"

Actually, because `PaperTrail` is a module, the use of a class
variable here is not as problematic as in an actual class, so
this change is solely to conform the the Ruby Style Guide.

> Avoid the usage of class (@@) variables due to their "nasty"
> behavior in inheritance.
> https://github.com/bbatsov/ruby-style-guide#no-class-vars

As stated above, because `PaperTrail` is a module, there is no
concern over inheritance, and this change is solely to conform
to the style guide.
14c5216
@jaredbeck jaredbeck Install rubocop 7d8775f
@jaredbeck jaredbeck Extract class: RecordHistory
The methods `#index`, `.subsequent`, and `.preceding` contain
duplicated logic re: how to order, chronologically, a set of
versions, specifically a set representing the history of a single
record.

The extracted class only supports `#index` so far, but it should
be possilbe to use in `.subsequent` and `.preceding` also.
a87dbfa
Commits on Nov 05, 2015
@jaredbeck jaredbeck Code style: Break long lines 3f4d87b
@jaredbeck jaredbeck Code style: ruby 1.9 hash syntax 4ca0ad1
@jaredbeck jaredbeck Code style: Avoid inline conditional on long lines 84b1ae5
@jaredbeck jaredbeck Comments re: method privacy 4d7b438
@jaredbeck jaredbeck Reduce duplication: extract local variable: limit
25f213b
@jaredbeck jaredbeck Merge pull request #642 from airblade/extract_record_history_class
Extract class: RecordHistory
ad37643
Commits on Nov 08, 2015
@jaredbeck jaredbeck Merge pull request #643 from airblade/ruby_style_guide
Ruby style guide
790cc60
@jaredbeck jaredbeck Merge pull request #641 from airblade/use_civ_not_cv
Use class inst. var. instead of class var.
f4818b6
@jaredbeck jaredbeck Minor, stylistic changes to VersionTest
- Prefer assert_match when testing with regex
- Prefer nested module syntax
- Fix argument order re: expected, actual
  - A common mistake in minitest.
8040011
@jaredbeck jaredbeck Fully qualified class name is not necessary
.. because we are (correctly) using nested module syntax.
43e1039
@jaredbeck jaredbeck Docs: .subsequent and .preceding e177db2
@jaredbeck jaredbeck Code style: Clarify how `reload` argument works 3a6df2c
@jaredbeck jaredbeck Require pry-nav in spec_helper
Already done in test_helper, enables pry when running a single
spec.
e9c7c70
@jaredbeck jaredbeck Merge pull request #644 from airblade/code_style_and_docs_20151108
Code style and docs 20151108
60df40f
@batter batter Merge pull request #640 from airblade/fix_issue_636
In track_associations, only check db if no config
cd04d16
Commits on Nov 09, 2015
@jaredbeck jaredbeck Docs: Changelog note re: issue 636
[ci skip]
b3e1dbd
Commits on Nov 11, 2015
@robmathews robmathews make 100% sure that the warning is accurate 097c89b
Commits on Nov 12, 2015
@jaredbeck jaredbeck Merge pull request #648 from GoodMeasuresLLC/more_accurate_warning
make 100% sure that the warning is accurate
9517c65
Commits on Nov 18, 2015
@jaredbeck jaredbeck Fix NameError: uninitialized constant JsonVersion 59cae39
@jaredbeck jaredbeck Fix incorrect decimal comparison delta
The column has a precision of 4, so the delta should be 0.0001.

See rails/rails#22325
2b26d92
@jaredbeck jaredbeck Merge pull request #649 from airblade/fix_name_error_in_json_version_…
…spec

Fix name error in json version spec
84bedae
Commits on Nov 26, 2015
@georgemillo georgemillo typo fix
--skip-ci
a148d70
Commits on Nov 27, 2015
@jaredbeck jaredbeck Merge pull request #655 from georgemillo/patch-1
typo fix
357d4a4
@jaredbeck jaredbeck Introduce bug report template
This template is based on the one used by the ActiveRecord
team. It's really convenient.

[ci skip]
385f3fe
@jaredbeck jaredbeck Merge pull request #658 from airblade/bug_template
Introduce bug report template
99a01b9
Commits on Nov 28, 2015
@jaredbeck jaredbeck Add links so people read the correct docs
[ci skip]
4f6a3cc
@jaredbeck jaredbeck Run rubocop linter before test suite
Most of the "cops" are wholly or partially disabled at this point.
As offenses are fixed, cops will move from `.rubocop_todo.yml` to
`.rubocop.yml`.

See
https://github.com/bbatsov/rubocop#automatically-generated-configuration
for details.
cbce4d3
@jaredbeck jaredbeck Merge pull request #660 from airblade/run_rubocop_before_tests
Run rubocop linter before test suite
416ce64
Commits on Dec 06, 2015
@seanlinsley seanlinsley Document how to migrate YAML data to JSON 1259762
Commits on Dec 07, 2015
@jaredbeck jaredbeck Specify required_ruby_version >= 1.9.3
0bf6881
@jaredbeck jaredbeck Merge pull request #666 from airblade/ruby_gte_1.9.3
Specify required_ruby_version >= 1.9.3
9a52507
Commits on Dec 11, 2015
@jaredbeck jaredbeck Merge pull request #665 from seanlinsley/patch-1
Document how to migrate YAML data to JSON
7856bcc
@jaredbeck jaredbeck Instructions for converting serialized columns
[ci skip]
c3ec7a8
Commits on Dec 13, 2015
@jaredbeck jaredbeck Extract method: object_changes_deserialized 62c520a
@jaredbeck jaredbeck Extract method: pt_recordable_object 95aae3f
@jaredbeck jaredbeck Extract method: pt_recordable_object_changes 6e857d8
@jaredbeck jaredbeck Extract method: pt_record_object_changes? 182a3eb
@jaredbeck jaredbeck Extract method: group_versions_by_date 78f0983
@jaredbeck jaredbeck Code style: Break long lines 3a72b7f
@jaredbeck jaredbeck Extract method: #load_changeset cfab26b
@jaredbeck jaredbeck Reduce duplication in Config#enabled
9c6c62d
@jaredbeck jaredbeck Merge pull request #661 from airblade/code_style_20151127
Code style: break long lines
ad91cc3
@jaredbeck jaredbeck Remove ruby 1.8 hacks
PaperTrail no longer supports ruby 1.8.
d030ba2
@jaredbeck jaredbeck Merge pull request #668 from airblade/remove_ruby_1.8_hacks
Remove ruby 1.8 hacks
7440ec1
Commits on Dec 14, 2015
@jaredbeck jaredbeck Issue 589 was backported to 4.0.1
[ci skip]
3fcf44b
@jaredbeck jaredbeck Update changelog: 3.0.9 and 4.0.1 released
[ci skip]
4e7a707
Commits on Dec 15, 2015
@jaredbeck jaredbeck Remove my own misleading comment
The `private` keyword does, in fact, make those instance methods
private. I think what I was trying to say is that the host class
(the class that VersionConcern is mixed into) will be able to use
these methods.  They *will* be private after being mixed in, but
they are not "api private", if that makes sense.

[ci skip]
df98728
Commits on Dec 16, 2015
@jaredbeck jaredbeck Docs: DDL to change column data type to json
Replaces #662

[ci skip]
c95086c
Commits on Dec 19, 2015
@jaredbeck jaredbeck Remove defunct: shoulda-matchers dce2514
@jaredbeck jaredbeck rspec 3.4 (was 3.1) 02a634f
@jaredbeck jaredbeck Style: Prefer if/else to unless/else 0e5b20e
@jaredbeck jaredbeck mysql2 0.4 (was 0.3)
Just a dev. dependency, no effect on library users.
10abe56
Commits on Dec 20, 2015
@jaredbeck jaredbeck ffaker 2.1 (was 1.31) 86f8c5d
@jaredbeck jaredbeck rake 10.4.2 (was 10.1.1)
1781521
@jaredbeck jaredbeck Merge pull request #674 from airblade/dev_deps
Update development dependencies
72d6367
@jaredbeck jaredbeck Notes on running postgres tests
[ci skip]
7280169
@jaredbeck jaredbeck Hopefully fix intermittent PG test fail in CI
Test would fail when FFaker::Color.name returned the same exact
string twice in a row. This is not FFaker's fault.

Incidentally, the FFaker color list currently has 19 entries.
(https://github.com/ffaker/ffaker/blob/master/lib/ffaker/data/color/names_list)
The test suite runs this postgres-specific test six times (3 rubies * 2 major
versions of rails). So, I think the chance of the test suite failing was
(1 / 19)^2 * 6, or 0.016, or about 2%.
811dc0e
@jaredbeck jaredbeck Simplify test data: fruit names
It's not clear to me that random test data makes this particular
test better.
f4cf6c1
@jaredbeck jaredbeck Merge pull request #675 from airblade/fix_intermittent_postgres_test
Hopefully fix intermittent postgres test
80e8934
@jaredbeck jaredbeck Print database version before CI tests
f9d2a2b
@jaredbeck jaredbeck Merge pull request #676 from airblade/print_db_vers_in_ci
Print database version before CI tests
94db843
Commits on Dec 21, 2015
@kaspth kaspth Use Active Record's type system from 4.2 onwards.
Rails 4.2 deprecates `serialized_attributes` without replacement. However,
it also introduces a type system which lets us treat all attributes the same.

Rails 4.2 has `type_for_attribute` which knows how to serialize and deserialize
itself from a database through `type_cast_for_database` and `type_cast_from_database`.

(In Rails 5 they will be `serialize` and `deserialize` respectively.)

Thus we no longer need the `PaperTrail.config.serialized_attributes` toggle,
and this change makes it do nothing. It's still kept around for backwardscompatibility.
5be48e4
@kaspth kaspth Add assertions to adjust timestamps on MySQL.
Tests were failing on MySQL due to timestamps with differing usec flunking
`assert_equal`.

Happened because Rails 4.2 added support for fractional seconds precision. Travis, however,
doesn't support the required MySQL 5.6 for it.

Bend the timestamps to strip out fractional seconds when tests are run with MySQL.
01837bf
@jaredbeck jaredbeck Merge pull request #667 from kaspth/revive-serialized-attributes
Use Active Record's type system from 4.2 onwards.
6df3532
Commits on Dec 22, 2015
@jaredbeck jaredbeck Deprecate PaperTrail.serialized_attributes?
This is a follow-up to PR 667
"Use Active Record's type system from 4.2 onwards."
6a91c73
Commits on Dec 23, 2015
@jaredbeck jaredbeck Merge pull request #679 from airblade/deprecate_ser_atr_accessor
Deprecate PaperTrail.serialized_attributes?
b059b8b
@jaredbeck jaredbeck Specify query order in STI test
This fixes an intermittent test failure where query sometimes
returned records in an order other than that in which they
were created. This is not a bug. Without an order clause, SQL
queries are expected to return records in any order.
fc07a4d
@jaredbeck jaredbeck Merge pull request #680 from airblade/fix_intermittent_cat_dog_test
Specify query order in STI test
402a78e
Commits on Dec 27, 2015
@jaredbeck jaredbeck MySQL: Specify utf8mb4 charset for versions table
Fixes #651
d138b95
@jaredbeck jaredbeck Merge pull request #681 from airblade/fix_651_mysql_charset
MySQL: Specify UTF-8 charset for versions table
eef918b
Commits on Jan 05, 2016
@jaredbeck jaredbeck Manage gemfiles with appraisal f812ea5
@jaredbeck jaredbeck Begin testing (not passing) against AR 5
9da84fb
Commits on Jan 07, 2016
@Amit-P-Amin Amit-P-Amin Fix Typo in Readme
Remove unnecessary 'a' in readme.
bd886c5
Commits on Jan 08, 2016
@jaredbeck jaredbeck Merge pull request #686 from Amit-P-Amin/patch-1
Fix Typo in Readme
9778ef7
@jaredbeck jaredbeck Merge pull request #684 from airblade/install_appraisal
Begin testing against AR 5
0aa2cab
@batter batter Remove old README header for feature where doc was removed 0cb68df
@jaredbeck jaredbeck Docs: bug report template: support tracking assocs
[ci skip]
06e6a41
Commits on Jan 14, 2016
@jaredbeck jaredbeck Begin testing against ruby 2.3.0
[Fixes #688]
33a13ca
@jaredbeck jaredbeck Merge pull request #690 from airblade/ruby-2.3.0
Begin testing against ruby 2.3.0
01d7480
@owenr owenr Call #reload instead of passing 'true' to relations
> Passing a truthy argument to force association to reload
> will be removed in Rails 5.1.
> https://github.com/rails/rails/blob/master/activerecord/CHANGELOG.md
986f8bd
@jaredbeck jaredbeck Merge pull request #691 from airblade/ar_5_assoc_reload
Call #reload instead of passing 'true' to relations
a40f3d5
Commits on Jan 15, 2016
@owenr owenr Use #capture_io instead of #capture when available (to handle depreca…
…tion)
de6f488
@owenr owenr Change paper_trail_on_destroy default to 'before'
Also warn if paper_trail_on_destroy(:after) is combined with
ActiveRecord belongs_to_required_by_default
18d35ef
@jaredbeck jaredbeck Reduce duplication in test by using lambda ebf6390
@jaredbeck jaredbeck Add .rbenv-gemsets to gitignore
I've seen rubymine adding this file recently. Since it's not
something we already use, it should be safe to ignore.
72fc13d
@jaredbeck jaredbeck Fix typo in contrib guide
[ci skip]
6ec7dfb
@jaredbeck jaredbeck Merge pull request #692 from airblade/capture_io
Use capture_io instead of capture (deprecated)
f8c8f7d
@jaredbeck jaredbeck Merge pull request #683 from owenr/master
Destroy callback default changed to :before
80bbb26
@jaredbeck jaredbeck Fix bundler warning: gem specified twice
The appraisal gemfile is supposed to override the gemspec, but
that doesn't seem to be happening for gems in the `platform`
section..
ef32eb5
@jaredbeck jaredbeck Improve speed of bundler resolution
We're seeing an issue with slow dependency resolution for
the AR3 gemfile, consistently taking 10 minutes on travis.
I am hoping that stricter version constraints will make
bundler's job easier.

If this doesn't improve the situation, we may have to try
debugging with `DEBUG_RESOLVER=1` turned on.
9852527
@jaredbeck jaredbeck Allow railties 5
4b7b738
@jaredbeck jaredbeck Merge pull request #693 from airblade/fix_slow_bundler_resolution
Various gemfile changes
a80c23f
Commits on Jan 18, 2016
@jaredbeck jaredbeck Docs: Clarify how to control order of AR callbacks
Backport: 4.1-stable

[ci skip]
7b1fa54
@jaredbeck jaredbeck Lint: Disable Style/BlockDelimiters c97eb17
@jaredbeck jaredbeck Update contrib. guide re: migrating PG test db e03d272
@jaredbeck jaredbeck Bind parameters in where_object{,_changes}
[Fixes #696]
033b135
@jaredbeck jaredbeck Merge pull request #697 from airblade/fix_issue_696_sqli
Bind parameters in where_object, where_object_changes
3420c86
@jaredbeck jaredbeck Docs: changelog for 033b135 (bind json params)
[ci skip]
e9b89ca
Commits on Jan 19, 2016
@batter batter Bump version number to 5.0.0.pre [ci skip] 6862abd
@owenr owenr Default order by timestamp to ensure early versions are cleaned c4e7b3c
Commits on Jan 20, 2016
@jaredbeck jaredbeck Merge pull request #701 from owenr/fix-cleaner
Default order by timestamp to ensure early versions are cleaned
cfcd11d
@batter batter Use Version#timestamp_sort_order for ordering of versions on Cleaner c200721
@jaredbeck jaredbeck Docs: Mention contr. callback more prominently
[Fixes #694]

[ci skip]
b9f23d7
@brandonhilkert brandonhilkert Fix link to Custom Serializer section
Looks like the heading changed at some point, not allowing one to easily click down to that section
4837084
@jaredbeck jaredbeck Merge pull request #702 from brandonhilkert/patch-1
Fix link to Custom Serializer section
01b76ce
Commits on Jan 23, 2016
@stgeneral stgeneral Remove duplicate link to RailsCast dc88252
Commits on Jan 24, 2016
@jaredbeck jaredbeck Merge pull request #704 from stgeneral/patch-1
Remove duplicate link to RailsCast
fc3b492
Commits on Jan 25, 2016
@owenr owenr Update PaperTrail and test suite for ActiveRecord 5 compatibility b9d9fb2
Commits on Jan 26, 2016
@jaredbeck jaredbeck Merge pull request #689 from owenr/pass_ar5_tests
Pass ar5 tests
d68587b
Commits on Feb 07, 2016
@jaredbeck jaredbeck Hide list of specs
When running rspec from rake, hide the list of specs.
(bit.ly/1nVq3Jn)
1d76256
@jaredbeck jaredbeck Docs: Update changelog re: release of 4.1
[ci skip]
1012b75
@jaredbeck jaredbeck Merge pull request #708 from airblade/hide_spec_list
Hide list of specs
9b44da5
@ankit1910 ankit1910 add documentation for paper_trail-globalid extentsion 30237e4
@jaredbeck jaredbeck Merge pull request #709 from ankit1910/add-doc
add documentation for paper_trail-globalid extentsion
d62b9fd