Does anyone want to take over PaperTrail? #155

Closed
airblade opened this Issue May 3, 2012 · 9 comments

Comments

Projects
None yet
5 participants
Owner

airblade commented May 3, 2012

I can't seem to find enough time these days to give PaperTrail the attention it deserves. Does anyone want to take it over?

Here's what you'd be signing up for:

  • The domain model has stood the test of time pretty well, but I think it could be a little more intuitive (#115, #124).
  • The code is clean and well commented.
  • The test code is harder to read than it should be. It uses an old version of Shoulda and has lots of nested contexts.
  • There are one or two edge cases to fix (#131, #88).
  • The big, unsolved problem is handling associations (#12, #44, #121, #148).
  • The code is tied to Rails 3. It would be nice to generalise it to support, say, Sinatra (#119).

I am gonna work using this gem for Rails 3 version. I can continue working on it. Let me know.

Owner

airblade commented May 8, 2012

@bhushangahire Thanks for the offer. Ideally I'd like someone who's already worked with PaperTrail a bit, and maybe even contributed code to it, but of course I don't want to rule anyone out.

Sure no issues.

m4tm4t commented Jun 19, 2012

I think (or not) I have a "way" for associations.

I have an Article model. It has many Page (polymorphic).

Basically, we can use the meta option

class Article
  has_paper_trail :on => [:update, :destroy], meta: {pages: Proc.new {|article| article.pages } }
  has_many :pages, as: :pageable, dependent: :delete_all
end
class Page
  belongs_to :pageable, :polymorphic => true, touch: true
end

the article is touched, but paper_trail don't care about updated_at column

Collaborator

batter commented Oct 11, 2012

@airblade - I would be willing to at least take a crack at merging the existing pull requests and seeing if I have time to continue working on it going forward if you're still looking for someone. Let me know.

Owner

airblade commented Oct 11, 2012

@batter Thank you! Try as I might I still haven't managed to find time for PaperTrail despite all the great pull requests piling up.

I've added you as a collaborator to the repo. Let me know if you have any queries and I'll do my best to get back to you quickly.

@batter Thank you for taking this over!

Any idea of when handling has manys might be added?

Collaborator

batter commented Dec 3, 2012

@stevenbristol - There were a few smaller features / issues I was going to address, for a 2.7.0 release. Hoping to address them and make a release before the holidays. I was planning on trying to tackle the has_many's and some other more complex tasks for a 3.0 release, but I wouldn't expect that to be ready until some time around February, as I will be travelling a lot in late December and January and won't have access to my computer for much of it.

If you or anyone else wants to take a crack at implementing, I'm open to looking at pull requests. #44 seems the most promising implementation attempt to date, but I haven't had the time to fully investigate and explore it. We want to make sure this is done properly, I'd like to avoid a shoddy implementation that is not sustainable for the long term.

See the Milestones Page for a tentative plan on release cycles.

Owner

airblade commented Jan 4, 2013

I'm closing this now: @batter is doing a superb job :)

@airblade airblade closed this Jan 4, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment