Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

widget.previous_version.next_version should return widget #324

Closed
randoum opened this Issue · 1 comment

2 participants

randoum Ben Atkins
randoum

Just reacting to the documentation:

As an aside, I'm undecided about whether widget.previous_version.next_version should return nil or self (i.e. widget). Let me know if you have a view.

I strongly feel that widget.previous_version.next_version should return self, it is important as those methods can be considered as iterator pointers, and could be called within a loop. We expect nil when we reach the top or bottom ends of the iterator, but not when we reach the "live" object (the live object is still a position within the iterator, not a end).

Excelent gem! Many thanks for the hard work

Ben Atkins
Collaborator

This has actually been the case since version 2.7.1 (see #200). Looks like I forgot to update the README accordingly, good catch!

Ben Atkins batter closed this in 6893431
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.