widget.previous_version.next_version should return widget #324

Closed
randoum opened this Issue Feb 1, 2014 · 1 comment

2 participants

@randoum

Just reacting to the documentation:

As an aside, I'm undecided about whether widget.previous_version.next_version should return nil or self (i.e. widget). Let me know if you have a view.

I strongly feel that widget.previous_version.next_version should return self, it is important as those methods can be considered as iterator pointers, and could be called within a loop. We expect nil when we reach the top or bottom ends of the iterator, but not when we reach the "live" object (the live object is still a position within the iterator, not a end).

Excelent gem! Many thanks for the hard work

@batter
Collaborator

This has actually been the case since version 2.7.1 (see #200). Looks like I forgot to update the README accordingly, good catch!

@batter batter closed this in 6893431 Feb 6, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment