Use class inst. var. instead of class var. #641
Conversation
I use the term "class instance variable" and "class variable" even though `PaperTrail` is a module. This nomenclature is conventional in ruby. > module A; @@x = :x; puts defined?(@@x); end > #=> "class variable" Actually, because `PaperTrail` is a module, the use of a class variable here is not as problematic as in an actual class, so this change is solely to conform the the Ruby Style Guide. > Avoid the usage of class (@@) variables due to their "nasty" > behavior in inheritance. > https://github.com/bbatsov/ruby-style-guide#no-class-vars As stated above, because `PaperTrail` is a module, there is no concern over inheritance, and this change is solely to conform to the style guide.
Use class inst. var. instead of class var.
|
My only question about this is regarding thread safety. I sone more or less thread safe? I know we brought in |
That's an important question. This should have no impact on thread safety. Both class variables (CV) and class instance variables (CIV) are equally thread-unsafe. That's why we use In a class, there's actually a small difference between CV and CIV (In short, CV are inherited/shared and CIV are not) but in a module there is no difference, because you can't inherit from a module. So, this change should have no effect. Basically, the ruby style guide says to never use CV (https://github.com/bbatsov/ruby-style-guide#no-class-vars), so this change just brings us in conformance with the style guide. |
I use the term "class instance variable" and "class variable"
even though
PaperTrailis a module. This nomenclature isconventional in ruby.
Actually, because
PaperTrailis a module, the use of a classvariable here is not as problematic as in an actual class, so
this change is solely to conform the the Ruby Style Guide.