Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #339: Display SVG files #341

Merged
merged 3 commits into from Mar 14, 2019

Conversation

Projects
None yet
2 participants
@klymenkoo
Copy link
Contributor

commented Mar 13, 2019

What

This PR contains a fix for #339: it displays SVG images, when the file was selected in file navigator:

Screen Shot 2019-03-12 at 10 11 23 PM

@dabbott
Copy link
Collaborator

left a comment

Nice! This looks good, just a couple minor style things.

Show resolved Hide resolved studio/LonaStudio/Documents/ImageDocument.swift Outdated
Show resolved Hide resolved studio/LonaStudio/Documents/ImageDocument.swift Outdated
@dabbott

This comment has been minimized.

Copy link
Collaborator

commented Mar 14, 2019

Awesome, great work!

I dunno what's up with the tests yet, but it's unrelated to this.

@dabbott dabbott merged commit d75301e into airbnb:master Mar 14, 2019

1 check failed

continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.