Export createDynamicImportTransform and getImportSource #75
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'd be very grateful if you could expose your internal transformation logic to use it in
@babel/plugin-proposal-dynamic-import
, which will then be used in@babel/preset-env
. (I will mention in the docs that, when targeting commonjs, it internally uses this plugin).Currently I'm working it around by doing this, but it is unnecessarily too hacky: link
Commit message:
If you prefer not to have
module.exports
in the source file, I could create two separate entry points:babel-plugin-dynamic-import-node
andbabel-plugin-dynamic-import-node/utils
, and export those new functions from the second one. I think that the current implementation is nicer.NOTE: This isn't blocking the Babel release, since the workaround is working for now. I can't use
getImportSource
for AMD yet, but it is a minor problem.