Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixing bug with applying policy to optional resource #141

Merged
merged 1 commit into from Feb 22, 2019
Merged

fixing bug with applying policy to optional resource #141

merged 1 commit into from Feb 22, 2019

Conversation

ryandeivert
Copy link
Contributor

to: @Ryxias
cc: @airbnb/binaryalert-maintainers

Background

I hadn't realized the logging bucket was optional, and applying a policy to a non-existent optional resource will fail.

Changes

  • Making bucket policy optional for the logging bucket (will only get applied if the resource also exists).

@ryandeivert ryandeivert added this to the v1.2.1 milestone Feb 22, 2019
@coveralls
Copy link

Coverage Status

Coverage remained the same at 92.2% when pulling 2ee0a90 on ryandeivert-fix-bug-with-optional-resource into af52374 on master.

@ryandeivert ryandeivert merged commit 1e06b94 into master Feb 22, 2019
@ryandeivert ryandeivert deleted the ryandeivert-fix-bug-with-optional-resource branch February 22, 2019 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ryxias Ryxias Ryxias approved these changes

Assignees
No one assigned
Labels
bug terraform
Projects
None yet
Milestone
v1.2.1
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ryandeivert @coveralls @Ryxias