New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add selectors and hostNodes section to migration guide #1408

Merged
merged 1 commit into from Dec 14, 2017

Conversation

Projects
None yet
2 participants
@dagda1
Copy link

dagda1 commented Dec 3, 2017

I created this after being unaware of the new behaviour in an attempted upgrade.

I have added an explanation about hostNodes in the migration guide.

This is in response to issue #1406.

@ljharb
Copy link
Member

ljharb left a comment

LGTM pending one change

const HelpLink = ({ text, ...rest }) => <a {...rest}>{text}</a>;
const HelpLinkContainer = ({ text, ...rest }) =>
<HelpLink text={text} {...rest} />;

This comment has been minimized.

@ljharb

ljharb Dec 4, 2017

Member

let's make sure these examples conform to the airbnb style guide; multiline jsx needs to be wrapped in parens

@dagda1 dagda1 force-pushed the dagda1:hostNodes branch from ba64790 to e649acb Dec 4, 2017

@dagda1 dagda1 force-pushed the dagda1:hostNodes branch from e649acb to 3f88c02 Dec 4, 2017

@dagda1

This comment has been minimized.

Copy link

dagda1 commented Dec 4, 2017

@ljharb My bad, I did not run the linter. Fixed now

@dagda1

This comment has been minimized.

Copy link

dagda1 commented Dec 14, 2017

@ljharb is there any feedback on this?

@ljharb

ljharb approved these changes Dec 14, 2017

Copy link
Member

ljharb left a comment

Looks great, thanks!

@ljharb ljharb force-pushed the dagda1:hostNodes branch from 3f88c02 to 3cfec3f Dec 14, 2017

@ljharb ljharb merged commit 3cfec3f into airbnb:master Dec 14, 2017

0 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
continuous-integration/travis-ci/push The Travis CI build is in progress
Details

@dagda1 dagda1 deleted the dagda1:hostNodes branch Dec 28, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment