Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Upgrade eslint-plugin-react in packages #1972
I started getting tired of seeing the red x next to my builds so I decided to figure out why the linter was failing. Lo and behold, @ljharb fixed the issue in
It looks like you upgraded the dependency in the top-level
P.S. I believe it is also a common monorepo pattern to only declare
I think it depends on what your goals are. If the goal is to make sure that the dependencies are the same across the entire project, no matter what, then it seems like a reasonable choice. You know what’s best for enzyme.
And whoops. I’ve been in yarn world for the past 2 years (where versions are locked in yarn.lock) so I forgot the bump wasn’t necessary.