Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upMake nodeToHostNode handle arrays #2001
Conversation
madicap
added some commits
Jan 31, 2019
madicap
requested a review
from
ljharb
Feb 4, 2019
ljharb
approved these changes
Feb 4, 2019
ljharb
added
the
MINOR
label
Feb 4, 2019
ljharb
merged commit bcb6fa9
into
master
Feb 4, 2019
ljharb
deleted the
mac--html-text-fragment-fixes
branch
Feb 4, 2019
added a commit
that referenced
this pull request
Feb 5, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
madicap commentedFeb 4, 2019
•
edited by ljharb
In order to resolve Issue #1799 and return expected .text() and .html() results for non-wrapped Fragments, nodeToHostNode in the react adapters needed to be able to handle arrays. This PR does that, changing
.text()and.html()to deal with an array of nodes while maintaining backwards compatibility for adapters returning single nodes.Fixes #1799.